Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 347017 - autoreconf not called with runShell
Summary: autoreconf not called with runShell
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Autotools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.8.0   Edit
Assignee: Jeff Johnston CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 12:14 EDT by Doug Schaefer CLA
Modified: 2011-06-02 18:34 EDT (History)
0 users

See Also:


Attachments
current java file (48.81 KB, text/plain)
2011-05-24 14:56 EDT, Jeff Johnston CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Schaefer CLA 2011-05-24 12:14:42 EDT
Just tested autotools on Windows and I see that autoreconf is called using runCommand. It needs to be called with runShell so that it runs correctly on Windows.
Comment 1 Jeff Johnston CLA 2011-05-24 14:08:32 EDT
The code is indeed calling runScript as part of the build.  Are you by any chance using the latest Indigo RC1?  The fix for runScript and autoreconf is not in this build.  It will be in RC2.
Comment 2 Doug Schaefer CLA 2011-05-24 14:38:59 EDT
I actually checked out the code from git running the master branch. I tried to create a patch but egit is broken right now for that (separate bug has been raised).

Once I got passed the runScript issue, I ran into two other issues. For some reason MSYS wasn't happy with 'sh reconfig -i', and I had to change it to 'sh -c "reconfig -i"'.

Then once I got past that, I found the PWD environment variable that CDT automatically sets to screw up configure. I just filtered it out before passing it to the launcher. I haven't checked but that may fix up the -c issue.
Comment 3 Jeff Johnston CLA 2011-05-24 14:56:45 EDT
Created attachment 196477 [details]
current java file

I have attached the current AutotoolsNewMakeGenerator.java.  Perhaps I am missing something, but autoreconf is using runScript which has your patch for adding sh -c to it for Windows.  Could you do a diff between your file and this one to make a patch?  If there is another file in question, let me know and I'll attach it here so you can do a diff and make a local patch.
Comment 4 Doug Schaefer CLA 2011-05-25 15:46:39 EDT
Ah, there we go. I did a pull and have the updated source.

The only thing left is to filter out the PWD environment variable when calling the script. configure still fails because of that.
Comment 5 Jeff Johnston CLA 2011-05-26 12:30:28 EDT
(In reply to comment #4)
> Ah, there we go. I did a pull and have the updated source.
> 
> The only thing left is to filter out the PWD environment variable when calling
> the script. configure still fails because of that.

Do you have a patch for this?  Is it simply to filter out PWD in the environment list loop when the tests that you added for using the runScript are true?  It's cutting it close for Indigo as RC2 is already out.  You have https://bugs.eclipse.org/bugs/show_bug.cgi?id=343879 open for the PWD issue
Comment 6 Doug Schaefer CLA 2011-05-26 14:20:12 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > Ah, there we go. I did a pull and have the updated source.
> > 
> > The only thing left is to filter out the PWD environment variable when calling
> > the script. configure still fails because of that.
> 
> Do you have a patch for this?  Is it simply to filter out PWD in the
> environment list loop when the tests that you added for using the runScript are
> true?  It's cutting it close for Indigo as RC2 is already out.  You have
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=343879 open for the PWD issue

Ah, too many things going on at once :). Yes it is as simple as filtering out in the loop. And we'll look to post Indigo to turn it off for everyone.

I'll copy this comment into 343879 and we can use that for this fix.