Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346962 - Choose... dialog for "File name patterns" should not change non-extension patterns
Summary: Choose... dialog for "File name patterns" should not change non-extension pat...
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 06:35 EDT by Markus Keller CLA
Modified: 2019-11-14 03:32 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-05-24 06:35:01 EDT 
I20110519-1138

In the File Search dialog, the Choose... dialog for "File name patterns" should not change non-extension patterns.

Currently, just clicking Choose... and then OK e.g. changes
*.properties, plugin.xml -> *.properties
!plugin.xml, *.xml -> *.!plugin.xml, *.xml

Looks like TypeFilteringDialog was only intended to be used to select extensions, not whole file name patterns. Unfortunately, the class Javadoc is completely wrong and the constructor Javadocs are also not helpful.
Comment 1 Dani Megert CLA 2011-05-24 08:17:38 EDT 
One of the problems is in TypeFilteringDialog when one enters a file name that is also registered as file type (see 'File Associations' page).

This is broken for years. Will take a look during 3.8.
Comment 2 Lars Vogel CLA 2019-11-14 03:32:40 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.