Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346934 - Don't hold header buffers while request is suspended
Summary: Don't hold header buffers while request is suspended
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 7.4.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 7.2.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 02:39 EDT by Greg Wilkins CLA
Modified: 2011-09-20 15:52 EDT (History)
2 users (show)

See Also:

Attachments
patch to release buffers (7.76 KB, patch)
2011-05-24 02:53 EDT, Greg Wilkins CLA 		no flags Details | Diff
patch to release buffers (9.03 KB, patch)
2011-05-24 05:31 EDT, Greg Wilkins CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Wilkins CLA 2011-05-24 02:39:36 EDT 
Jetty currently releases content buffers while a request is suspended, but request header buffers are 8k and can consume a lot of memory for lots of connections.

These buffers could be release if the HttpFields instance was updated to give up references to the buffer for the raw bytes.
Comment 1 Greg Wilkins CLA 2011-05-24 02:53:27 EDT 
Created attachment 196396 [details]
patch to release buffers
Comment 2 Greg Wilkins CLA 2011-05-24 05:31:31 EDT 
Created attachment 196414 [details]
patch to release buffers

this is working better, but there are still failures in cometd load tests
Comment 3 Greg Wilkins CLA 2011-09-06 01:06:23 EDT 
fixed in 7.5.0
Comment 4 Jesse McConnell CLA 2011-09-20 15:52:31 EDT 
Resolved -> Closed