Community
Participate
Working Groups
Created attachment 196377 [details] screenshot using orion.eclipse.org I opened a git log page. I got tripped up by the commit details area on the page. 1. The "Choose commit..." message confused me. I thought maybe I should choose something from the left hand side, but that it was empty. Then I remembered Szymon telling me he was going to use the left hand side for commit details. So I clicked in the right hand side. Then I understood what was going on. 2. It just "feels weird" to me to have a master/details pattern here where the details is on the left. In Orion, we have the outliner on the left, the favorites on the left, etc. In Eclipse, we almost always do master/details left to right. The only exception I can think of is code outliner, but you could even argue that is more a navigation thing than master/details. Regardless of terminology, it definitely takes some getting used to (i'm not used to it yet). 3. I expected ctrl-click of the commit details to take me to a new page of commit details. This is because the outliner and the navigator use this convention. Click on the link navigates and stays on page, ctrl-click opens a new page. Suggestions are: - replace "Choose commit..." heading with "Commit Details" - move that pane to the right of the log - not sure what to do about control click, but if we ever have another reason to provide commit details on a separate page, then we should ensure that ctrl-click will take you there.
(In reply to comment #0) > 2. It just "feels weird" to me to have a master/details pattern here where the > details is on the left. In Orion, we have the outliner on the left, the > favorites on the left, etc. In Eclipse, we almost always do master/details left > to right. The only exception I can think of is code outliner, but you could > even argue that is more a navigation thing than master/details. Regardless of > terminology, it definitely takes some getting used to (i'm not used to it yet). The version on orion.eclipse.org is not up-to-date. The latest Orion has the commit list on the left and the details on the right. The details pane is closed by default. You need to click on a commit to open it and see the details. > Suggestions are: > - replace "Choose commit..." heading with "Commit Details" Ok. > - move that pane to the right of the log Already done. > - not sure what to do about control click, but if we ever have another reason to > provide commit details on a separate page, then we should ensure that ctrl-click > will take you there. If we want to have the commit details on a separate page, please raise a bug for it and assign to me. Or just change the summary of the bug to address ctrl-click behavior.
I'll try to remember to check against the latest code when observing problems on I-builds. (I'm trying to stay completely in the "cloud" workflow where possible). If details is on the right and the heading gets changed, you can close this bug. I suspect I might not have even thought about ctrl-click if I hadn't been weirded out by the right/left thing.
(In reply to comment #2) > If details is on the right and the heading gets changed, you can close this bug. > I suspect I might not have even thought about ctrl-click if I hadn't been > weirded out by the right/left thing. The heading is changed with e980917a743b6a5703c1a1284be18992e96f8de4.
