Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346898 - Commit activity statistics to include both author and committer
Summary: Commit activity statistics to include both author and committer
Status: RESOLVED WONTFIX
Alias: None
Product: Dash
Classification: Technology
Component: Commits Explorer (Retired) (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Dash Incoming bugs CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-23 13:50 EDT by Ryan Brooks CLA
Modified: 2016-04-18 09:55 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Brooks CLA 2011-05-23 13:50:56 EDT
A number of active committers on the org.eclipse.osee project are listed as inactive.  My hypothesis is that this is due to the activity statistics being computed by looking at the committer only.  If this is the case, the author needs to be included as well.

For example:

$ git show --format=fuller 5bb689c
commit 5bb689ca3f03ab95ed69b78dac7a3263ffd87326
Author:     jphillips <jeff.c.phillips@boeing.com>
AuthorDate: Fri May 13 13:33:46 2011 -0700
Commit:     Ryan D. Brooks <ryan.d.brooks@boeing.com>
CommitDate: Fri May 13 13:33:46 2011 -0700


Thanks,
Ryan Brooks
Comment 1 Denis Roy CLA 2011-05-24 10:06:01 EDT
Moving to the project dashboards.
Comment 2 Wayne Beaton CLA 2011-05-24 10:26:58 EDT
By design, Dash is intended to record commits. This is semantically different from recording the bits authored, but I believe that it makes sense to do so.

What should the semantics be?

If the author is a committer, then the author gets credit. Does the committer get credit as well?

Is there some reason why Jeff isn't committing work that he's authored?

I have been thinking (Tweeted about it over the weekend) about capturing Author information so that we can use it to generate the contributions section of the IP Log.
Comment 3 Chris Aniszczyk CLA 2011-05-24 10:28:45 EDT
(In reply to comment #2)
> Is there some reason why Jeff isn't committing work that he's authored?

It would be because Jeff isn't a committer and wrote a patch :)

In Git, author is separated from committer, which is extremely useful for the IP process imho...
Comment 4 Wayne Beaton CLA 2011-05-24 10:36:50 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > Is there some reason why Jeff isn't committing work that he's authored?
> 
> It would be because Jeff isn't a committer and wrote a patch :)

As of October 2007, Jeff is a committer. What else have you got, smart guy?

> In Git, author is separated from committer, which is extremely useful for the
> IP process imho...

Agreed. In fact, I think I recall reading that somewhere :-)
Comment 5 Ryan Brooks CLA 2011-05-24 20:04:12 EDT
Git supports a variety of development workflows through its rich feature set especially the rebase command.  When rebase is used, the committer is recorded as the committer who performed the rebase rather than the committer who originally authored and pushed the change.  The author continues to be reported as the original code author.

I would say that the author's contribution represents the more meaningful portion of the participation in the committer/author distinction.  However, I would recommend also counting the committer has having materially participated.  When the committer is applying a patch, then he is also performing a review.  In the case of a rebase (for which there are a number of scenarios) the committer is performing important administrative functions.  It is even conceivable that this work is being done by someone (like a build master) who may not otherwise be making commits.
Comment 6 Eclipse Genie CLA 2014-04-27 01:36:38 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 7 Eclipse Genie CLA 2016-04-17 05:31:46 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Wayne Beaton CLA 2016-04-18 09:55:19 EDT
The new dashboard [1], as well as all of the charts on the project (PMI) pages use the author field to record the source of contributions.

We have no plans to update the deprecated (old) dashboard.

I think that the intention of this issue has been fully addressed. The letter of it, however, has not been addressed, so I'm going to mark this as WONTFIX.


[1] http://dashboard.eclipse.org