Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346889 - Document File Name Pattern Exclusion
Summary: Document File Name Pattern Exclusion
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.2   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 134627
Blocks:
  Show dependency tree
 
Reported: 2011-05-23 12:15 EDT by Markus Keller CLA
Modified: 2012-04-27 07:31 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-05-23 12:15:54 EDT 
+++ This bug was initially created as a clone of Bug #134627 +++

I found the File Name Pattern Exclusion feature by chance because I was reading the code. We need to

a) document this in the UI (e.g. add ", !x = excluding x") to the label

b) add this to the help with an example (e.g. "!plugin.xml, *.xml")

c) fix the implementation of the Choose... dialog (which mangles the pattern from (b) into this when I just click Choose..., OK: "*.!plugin.xml, *.xml")
Comment 1 Dani Megert CLA 2011-05-24 01:38:41 EDT 
I didn't know this exists either ;-).
Comment 2 Markus Keller CLA 2011-05-24 06:37:27 EDT 
> c) fix the implementation of the Choose... dialog (which mangles the pattern
> from (b) into this when I just click Choose..., OK: "*.!plugin.xml, *.xml")

Moved this into separate bug 346962, since it's a general problem of the dialog (not only in connection with exclusion patterns). The exclusion patterns implementation is fine.
Comment 3 Dani Megert CLA 2012-04-27 03:38:43 EDT 
> b) add this to the help with an example (e.g. "!plugin.xml, *.xml")

Fixed in master: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=ad8a94a12f0b5c66cf4f62c5dda9bb7b725abec9
Comment 4 Dani Megert CLA 2012-04-27 07:31:48 EDT 
> a) document this in the UI (e.g. add ", !x = excluding x") to the label

Fixed in master: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=cb22879bf494abef4f0249f6c7cbb839abbb3a90