Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346852 - Export Test Result Details in the Test Result Summary View is misnamed
Summary: Export Test Result Details in the Test Result Summary View is misnamed
Status: CLOSED FIXED
Alias: None
Product: Jubula
Classification: Technology
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: Kepler   Edit
Assignee: Zeb Ford-Reitz CLA
QA Contact: Oliver Goetz CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-23 06:57 EDT by Tim Winselmann CLA
Modified: 2012-10-09 08:27 EDT (History)
3 users (show)

See Also:


Attachments
stack trace of method call that resets contribution label to wizard name (3.19 KB, text/plain)
2012-02-24 04:22 EST, Zeb Ford-Reitz CLA
no flags Details
patch for explicitly setting the contribution label (1.10 KB, text/plain)
2012-02-24 04:25 EST, Zeb Ford-Reitz CLA
no flags Details
patch for explicitly setting the contribution label (1.11 KB, patch)
2012-02-24 04:30 EST, Zeb Ford-Reitz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Winselmann CLA 2011-05-23 06:57:38 EDT
Export Test Result Details in the Test Result Summary View is misnamed and has a wrong icon. If you open the context menu on a Test Result Summary the last point is "Test Result Details", which is decorated like the "Open in Test Result Viewer". This option should be named "Export" and get the right icon.
Comment 1 Markus Tiede CLA 2011-05-24 08:13:49 EDT
Fixed label with 

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=7313b0ca57665bf353937143e60b05c409362653

I think we should simply enhance / change the icon to differ from "Open in Test
Result Viewer"-action. Please verify label change and create / alter icon (@TW).
Comment 2 Tim Winselmann CLA 2011-05-25 10:01:31 EDT
The label is still "Test Result Details".
Comment 3 Zeb Ford-Reitz CLA 2012-02-24 04:22:44 EST
Created attachment 211560 [details]
stack trace of method call that resets contribution label to wizard name

The contribution label, even if explicitly set in plugin.xml, gets reset automagically to the wizard name. I've attached a stack trace of where this occurs.
Comment 4 Zeb Ford-Reitz CLA 2012-02-24 04:25:52 EST
Created attachment 211561 [details]
patch for explicitly setting the contribution label

I'm attaching the patch to explicitly set the contribution label even though it proved ineffective.
Comment 5 Zeb Ford-Reitz CLA 2012-02-24 04:29:37 EST
Resolving as WONTFIX because the label (and icon) cannot be set explicitly. They are fully dependent on the wizard name and icon. Changing the wizard name and icon would cause the wizard to appear incorrectly in the general export wizard dialog (i.e. all other wizards would be named based on *what* they export, and this wizard would be named "Export" or "Export Test Result Details...").
Comment 6 Zeb Ford-Reitz CLA 2012-02-24 04:30:41 EST
Created attachment 211562 [details]
patch for explicitly setting the contribution label
Comment 7 Alexandra Schladebeck CLA 2012-04-20 02:04:33 EDT
Closing this ticket
Comment 8 Zeb Ford-Reitz CLA 2012-09-25 09:45:23 EDT
A possible solution occurred to me while working on another problem:
Add a new Command (and corresponding Handler) for "Export Test Result Details" and add this Command to the toolbar / menu instead of the parameterized Export Wizard Command. The Handler could then invoke the parameterized Export Wizard Command.

This solution (if workable) provides more fine-grained control over:
 * name (Export Test Result Details)
 * icon (an "export" arrow in addition to the Test Results icon)
 * enablement (disabled if no Test Result Summaries with details are selected)
 * error handling (if an error occurs while processing the selection, we could present a dialog instead of the export wizard)

If this solution proves workable, it might be worth applying it to otehr wizards in Jubula (ex. Import Central Test Data).
Comment 10 Zeb Ford-Reitz CLA 2012-10-05 06:34:51 EDT
Comment on attachment 211560 [details]
stack trace of method call that resets contribution label to wizard name

This attachment did not contribute in any way to the solution that was actually used.
Comment 11 Zeb Ford-Reitz CLA 2012-10-05 06:35:17 EDT
Comment on attachment 211562 [details]
patch for explicitly setting the contribution label

This attachment did not contribute in any way to the solution that was actually used.
Comment 12 Oliver Goetz CLA 2012-10-09 08:27:15 EDT
Tested using current GD.