Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346801 - [wizard] complains about discouraged package name if base class is a nested class
Summary: [wizard] complains about discouraged package name if base class is a nested c...
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.8   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 2.0 RC2   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-21 18:37 EDT by Stephan Herrmann CLA
Modified: 2011-06-02 11:17 EDT (History)
0 users

See Also:


Attachments
Fix (2.01 KB, patch)
2011-05-21 18:53 EDT, Stephan Herrmann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-05-21 18:37:37 EDT
I came across this in the following situation:

team class Outer {
   protected team class Mid {
      // invoke new role wizard here
   }
}

enter a role name and select Outer.Mid as the base class.
We get a complaint that Outer.Mid is a discouraged name,
because the qualifier is interpreted as a package name.

Instead, if the type already exists we should not check with
JavaConventions.
Comment 1 Stephan Herrmann CLA 2011-05-21 18:53:14 EDT
Created attachment 196281 [details]
Fix

Implemented by first asking the enclosingType to resolve the base class,
and only if no result ask JavaConventions.
Comment 2 Stephan Herrmann CLA 2011-05-21 18:54:37 EDT
Committed as r1615.
Comment 3 Stephan Herrmann CLA 2011-06-02 11:17:12 EDT
Verified using build 201105311237