Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346741 - [1.7][doc] Update doc when java 1.7 support is done
Summary: [1.7][doc] Update doc when java 1.7 support is done
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Ayushman Jain CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 13:04 EDT by Ayushman Jain CLA
Modified: 2011-08-25 06:11 EDT (History)
3 users (show)

See Also:


Attachments
proposed fix (19.44 KB, patch)
2011-08-08 07:00 EDT, Ayushman Jain CLA
daniel_megert: review-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ayushman Jain CLA 2011-05-20 13:04:26 EDT
Currently, the jdt_api_options file and the javadoc of JavaCore#VERSION_1_7 have a note implying that compiler does not support 1.7 currently. (HEAD)

This note should be removed when 1.7 support is done.

Other documentation regarding new options/APIs introduced for java 7 support should also be updated.
Comment 1 Srikanth Sankaran CLA 2011-07-14 20:53:00 EDT
For 3.7.1, we will not have full documentation update pass.
N & N will capture the highlights.
Comment 2 Ayushman Jain CLA 2011-08-08 07:00:15 EDT
Created attachment 201072 [details]
proposed fix

Fixed the doc for 1.7 support and also removed API filters.
Comment 3 Ayushman Jain CLA 2011-08-08 07:06:51 EDT
Released in HEAD for 3.8M2
Comment 4 Dani Megert CLA 2011-08-09 05:59:56 EDT
Comment on attachment 201072 [details]
proposed fix

This patch is not good for two reasons:
- it introduces CHKPII errors
- it has unrelated changes to the API filters which causes API Tools errors

Correct fix is in
/org.eclipse.jdt.doc.isv/guide/jdt_api_options.htm rev. 1.92.
Comment 5 Dani Megert CLA 2011-08-09 06:05:30 EDT
I've also committed the changes to R3_7_maintenance.
Comment 6 Srikanth Sankaran CLA 2011-08-25 06:00:14 EDT
(In reply to comment #5)
> I've also committed the changes to R3_7_maintenance.

Where exactly would this text (not) show up in the help UI ? 
OIOW, how should I verify this ?
Comment 7 Dani Megert CLA 2011-08-25 06:06:57 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > I've also committed the changes to R3_7_maintenance.
> 
> Where exactly would this text (not) show up in the help UI ? 
> OIOW, how should I verify this ?

I don't get the question? I only fixed bugs in the previous patch.
Comment 8 Ayushman Jain CLA 2011-08-25 06:08:44 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > I've also committed the changes to R3_7_maintenance.
> > 
> > Where exactly would this text (not) show up in the help UI ? 
> > OIOW, how should I verify this ?
> 
> I don't get the question? I only fixed bugs in the previous patch.

Help> JDT plugin developer guide> programmer's guide> jdt core> jdt core options
Comment 9 Srikanth Sankaran CLA 2011-08-25 06:11:09 EDT
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > I've also committed the changes to R3_7_maintenance.
> > 
> > Where exactly would this text (not) show up in the help UI ? 
> > OIOW, how should I verify this ?
> 
> I don't get the question? I only fixed bugs in the previous patch.

I was asking for the breadcrumb trail to the page where the modification
would appear in the help UI.

Ayush pointed me to it: JDT Plug-in Developer Guide > Programmer's Guide > JDT
Core > JDT Core options

Verified for 3.7.1 RC2 using Build id: M20110824-0800.