Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346679 - [Compatibility] Team->History causes eclipse/java to hang/freeze (indefinitely?)
Summary: [Compatibility] Team->History causes eclipse/java to hang/freeze (indefinitely?)
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 09:47 EDT by John CLA
Modified: 2011-05-28 12:40 EDT (History)
4 users (show)

See Also:


Attachments
stack trace (also known as thread dump) (21.00 KB, text/plain)
2011-05-20 10:11 EDT, John CLA
no flags Details
another thread dump when got stuck / eclipse freeze (29.51 KB, text/plain)
2011-05-26 22:07 EDT, John CLA
no flags Details
SelectionService patch v1 (1.85 KB, patch)
2011-05-27 10:42 EDT, Remy Suen CLA
no flags Details | Diff
these are the installed stuff in Eclipse SDK Version: 4.1.0 Build id: I20110526-2200 (50.13 KB, image/png)
2011-05-27 17:23 EDT, John CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John CLA 2011-05-20 09:47:12 EDT
Build Identifier: I20110518-2200 Version: 4.1.0

if History view is active and you click on a project that uses svn then eclipse hangs indefinitely(I assume) and a forced kill is needed which possibly causes you to loose any unsaved files(?)

but if you click on the project and then activate the History view, then it doesn't hang.

Reproducible: Always

Steps to Reproduce:
Have these installed:
  Subversive SVN Team Provider (Incubation)	0.7.9.I20110419-1700	org.eclipse.team.svn.feature.group	Eclipse.org
  SVNKit 1.3.5 Implementation (Optional)	2.2.2.I20110419-1700	org.polarion.eclipse.team.svn.connector.svnkit16.feature.group	Polarion Software
  Subversive SVN Connectors	2.2.2.I20110419-1700	org.polarion.eclipse.team.svn.connector.feature.group	Polarion Software

I also had EGIT installed, if this is relevant (but no open projects that use it)

1. create a (java)project then close it
2. create another project that uses svn, or rather import it from svn (ie. project named `jme3` from http://jmonkeyengine.googlecode.com/svn/trunk/engine )
3. keep this project open
4. click on the first (closed) project
5. make sure this view is open now: Window->Show View,  Team->History
6. close eclipse then start it again,
7. click on the first (closed) project 
8. make sure the History view is active
9. now click on the jme3 project (in package explorer <- implied)
this will freeze eclipse,
 Problem Event Name:	AppHangB1
  Application Name:	javaw.exe
  Application Version:	6.0.250.6
was using C:/Program Files/Java/jdk1.6.0_25/bin/javaw.exe   to run eclipse in.

to workaround this, replace step 8. with:
8. make sure History view is not active ie. activate Console view instead
execute same step 9. aka click on jme3 project (in package explorer that is)
10. now activate the History view
now nothing happens, no refresh is done but no eclipse freezing either
11. click either the jme3 project name(in pkg. explorer) OR inside the view space in History view to cause a refresh to happen
and no freezing of eclipse happens.

after this even if you click on other projects which cause the History view contents to change and then click back on the jme3 project (which uses svn) eclipse won't block


thanks to Trudko on irc which caused me to hit this bug
Comment 1 John CLA 2011-05-20 10:11:21 EDT
Created attachment 196221 [details]
stack trace (also known as thread dump)

java version "1.6.0_25"
Java(TM) SE Runtime Environment (build 1.6.0_25-b06)
Java HotSpot(TM) 64-Bit Server VM (build 20.0-b11, mixed mode)
Comment 2 John CLA 2011-05-20 10:23:23 EDT
apparently somewhere after some forced close(kill eclipse) this option got deselected: Window->Preferences->General->Appearance->Label Decorations->SVN
and selecting it had no effect until after I restarted eclipse. Oh well, it's probably nothing ;)
Comment 3 John CLA 2011-05-26 22:07:55 EDT
Created attachment 196720 [details]
another thread dump when got stuck / eclipse freeze

done in this eclipse:
Eclipse SDK

Version: 4.1.0
Build id: I20110526-1435
Comment 4 Paul Webster CLA 2011-05-27 08:32:15 EDT
I thought it might be related to bug 344033 but that was "fixed" back in 04/28.

PW
Comment 5 Remy Suen CLA 2011-05-27 09:36:24 EDT
John, you use secure storage to store your passwords, correct?
Comment 6 Remy Suen CLA 2011-05-27 10:42:46 EDT
Created attachment 196768 [details]
SelectionService patch v1

Though @GroupUpdates is not working properly see (bug 342992 and bug 342994), moving forward I think we should let @GU handle post selection notifications. Right now we're sending out two post selection events for each selection call due to a listener chain. Removing the service's post selection listener on workbench parts will fix this problem. A post selection event is forwarded out consumers anyway when a regular selection is made so there should be no loss of functionality here.
Comment 7 Remy Suen CLA 2011-05-27 11:44:02 EDT
(In reply to comment #6)
> Created attachment 196768 [details]
> SelectionService patch v1

Patch released to CVS HEAD.

John, please verify the fix when you get a chance, thanks.
Comment 8 John CLA 2011-05-27 16:56:16 EDT
(In reply to comment #5)
> John, you use secure storage to store your passwords, correct?

I don't know, if I do it's without my knowledge(?) 
there are some settings there at least for that jme3 project with googlecode's location

anyway bug seems to be fixed in:
Eclipse SDK

Version: 4.1.0
Build id: I20110526-2200

awesome! ;)
Comment 9 Remy Suen CLA 2011-05-27 17:01:43 EDT
(In reply to comment #8)
> Build id: I20110526-2200

Actually, that build doesn't have my fix in it... :o
Comment 10 John CLA 2011-05-27 17:06:08 EDT
(In reply to comment #9)
> (In reply to comment #8)
> > Build id: I20110526-2200
> 
> Actually, that build doesn't have my fix in it... :o

I understand what you mean, it's a bit interesting since this bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=346679
was 1 hour and 10 mins earlier and that seems to have been fixed, (unless I mis-tested it). I was guessing you probably initiated the build right after you patched that one, so this one was not in the probably-copied for build tree..
Comment 11 John CLA 2011-05-27 17:07:32 EDT
ok ignore Comment 10, I though I was posting on the other bug, but how come, since it doesn't have the fix... odd, probably I didn't do the test right? I don't get it xD
Comment 12 John CLA 2011-05-27 17:11:14 EDT
I did notice that there was a SVN update with this eclipse (that build), since I installed them via Help->Check For Updates,
possibly svn fixed it? I don't know...
I will try to get the original build and retry the bug and make sure it does happen then come back to this build and test again, if it's indeed fixed and I'm reproducing it right (ie. missing mercurialeclipse atm, don't know if it's relevant)
Comment 13 Remy Suen CLA 2011-05-27 17:12:17 EDT
(In reply to comment #12)
> I will try to get the original build and retry the bug and make sure it does
> happen then come back to this build and test again, if it's indeed fixed and
> I'm reproducing it right (ie. missing mercurialeclipse atm, don't know if it's
> relevant)

Hi John, thanks for your help. From what I understand, the Subversion plug-in is the only plug-in that's required to trigger the problem.
Comment 14 John CLA 2011-05-27 17:23:04 EDT
Created attachment 196816 [details]
these are the installed stuff in Eclipse SDK  Version: 4.1.0 Build id: I20110526-2200

(In reply to comment #13)
> Hi John, thanks for your help. From what I understand, the Subversion plug-in
> is the only plug-in that's required to trigger the problem.

Indeed it is so, and I tested bug again in:
Eclipse SDK

Version: 4.1.0
Build id: I20110518-2200

and it's there, then I updated only SVN stuff (see picture) and magically it's fixed, note: I had EGIT installed (all the time, if this matters)
Anyway seems to me, the updated SVN stuff (even though dated earlier) did fix this bug or well it's no longer there...
Let me know if I need to clarify more,
Peace out:)
Comment 15 John CLA 2011-05-27 17:27:02 EDT
oh dear, looks like something happened and eclipse got updated too (since I copy pasted the build id in prev comment), this means, eclipse and SVN stuff both got updated, I coulda sworn I chose only SVN stuff to be updated!

I'll retry or something, then my previous comment means that bug got fixed when installing SVN updates and eclipse update to build: Eclipse SDK

Version: 4.1.0
Build id: I20110526-2200
Comment 16 Remy Suen CLA 2011-05-27 17:28:59 EDT
(In reply to comment #14)
> Anyway seems to me, the updated SVN stuff (even though dated earlier) did fix
> this bug or well it's no longer there...

Hi John, I think it must have been from Subversive's fix for bug 313866.

Thank you very much for your help. Please let us know if you encounter
other problems using Eclipse 4.1.
Comment 17 Remy Suen CLA 2011-05-27 17:37:50 EDT
I have reverted the patch since Subversive has fixed the problem on their end.
Comment 18 John CLA 2011-05-28 12:40:06 EDT
yeah, sorry about you having to dispose of the work you've done. I don't know about others but I personally do not appreciate when that happens. Cumulative is desired instead...or something along those lines.

marked as resolved then ..
Thank yous are implied :P