Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346659 - [misc] FilterMessages is a copy of Messages - causing NLS warnings
Summary: [misc] FilterMessages is a copy of Messages - causing NLS warnings
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Michael Rennie CLA
URL:
Whiteboard:
Keywords:
: 346661 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-05-20 08:10 EDT by Ian Tewksbury CLA
Modified: 2011-09-23 11:43 EDT (History)
3 users (show)

See Also:
thatnitind: review+
karasiuk: review+

Attachments
Fix patch (2.78 KB, patch)
2011-05-20 08:11 EDT, Ian Tewksbury CLA 		no flags Details | Diff
fix for HEAD (7.48 KB, patch)
2011-06-07 12:09 EDT, Michael Rennie CLA 		no flags Details | Diff
fix for 3.2.5 (9.35 KB, patch)
2011-06-07 12:10 EDT, Michael Rennie CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-05-20 08:10:19 EDT 
The org.eclipse.wst.jsdt.debug.internal.ui.filters.FilterMessages NLS class points tot he same properties file as org.eclipse.wst.jsdt.debug.internal.ui.Messages, but only references one string.  The FilterMessages class should be removed and the one reference to it should be updated to point to the Messages class instead.
Comment 1 Ian Tewksbury CLA 2011-05-20 08:11:19 EDT 
Created attachment 196205 [details]
Fix patch

Patch that removes redundant FilterMessages class and updates the one reference to it to use existing Messages class.
Comment 2 Gary Karasiuk CLA 2011-05-20 08:20:11 EDT 
(In reply to comment #1)
Whoops, I just opened bugzilla 346661 for this problem and submitted a different patch :-) 

I think that the FilterMessages class is still needed in order to prevent some unwanted bundle activation cases.
Comment 3 Nitin Dahyabhai CLA 2011-05-23 10:13:51 EDT 
(In reply to comment #2)
> (In reply to comment #1)
> Whoops, I just opened bugzilla 346661 for this problem and submitted a
> different patch :-) 
> 
> I think that the FilterMessages class is still needed in order to prevent some
> unwanted bundle activation cases.

You're right.
Comment 4 Michael Rennie CLA 2011-05-24 10:31:09 EDT 
(In reply to comment #3)
> 
> You're right.

This seems to be fallout from fix for bug 320407. I think the best solution to this would be to remove the filter - which no longer seems to be working anyway - and the offending messages file.
Comment 5 Nitin Dahyabhai CLA 2011-05-24 16:41:02 EDT 
Very well.  We'll do that.
Comment 6 Michael Rennie CLA 2011-06-07 12:09:49 EDT 
Created attachment 197512 [details]
fix for HEAD

Here is a patch that removes the filter completely from HEAD
Comment 7 Michael Rennie CLA 2011-06-07 12:10:27 EDT 
Created attachment 197513 [details]
fix for 3.2.5

here is the fix for 3.2.5
Comment 8 Michael Rennie CLA 2011-06-07 12:11:57 EDT 
*** Bug 346661 has been marked as a duplicate of this bug. ***
Comment 9 Michael Rennie CLA 2011-06-07 12:14:14 EDT 
Nitin, Gary, please review the patches
Comment 10 Gary Karasiuk CLA 2011-06-07 12:49:54 EDT 
(In reply to comment #9)
> Nitin, Gary, please review the patches

Looks ok to me.
Comment 11 Chris Jaun CLA 2011-06-16 17:34:40 EDT 
Is this all ready to be checked in?
Comment 12 Michael Rennie CLA 2011-06-17 12:19:29 EDT 
(In reply to comment #11)
> Is this all ready to be checked in?

Yes.
Comment 13 Chris Jaun CLA 2011-06-21 10:09:08 EDT 
Checked into HEAD and 3.2.5.