Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346611 - [Theming][Scrollbar] up and down button icons are mistaken
Summary: [Theming][Scrollbar] up and down button icons are mistaken
Status: CLOSED INVALID
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 05:34 EDT by Holger Staudacher CLA
Modified: 2012-07-17 03:29 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-05-20 05:34:20 EDT
I styled a scrollbar and noticed that the ScrollBar-DownButton-Icon and ScrollBar-UpButton-Icon are mistaken. This only effects the vertical style. I think this will confuse most of the users and need to be fixed for 1.4.
Comment 1 Ivan Furnadjiev CLA 2011-05-23 09:17:38 EDT
By UpButton and DownButton we mean a button to increase and decrease the value, but not the position on the screen. Maybe better naming will be IncreaseButton and DecreaseButton, but it's too late to change it for 1.4. More over we have the same naming in Slider as well. Strange enough, in SWT (same in RAP) in vertical ScrollBar/Slider the smaller value is on the top.
Comment 2 Ivan Furnadjiev CLA 2011-05-23 09:20:00 EDT
As the theming documentation says:
ScrollBar-DownButton = "The button for decreasing selection value"
ScrollBar-UpButton = "The button for increasing selection value"
Comment 3 Ralf Sternberg CLA 2011-10-27 05:12:51 EDT
Maybe ScrollBar-LeftButton-Icon and ScrollBar-RightButton-Icon would have been a better choice. Now you have to use ScrollBar-UpButton-Icon[HORIZONTAL] and ScrollBar-DownButton-Icon[HORIZONTAL] instead. I think the idea was that "up" and "down" refers to the value of the scrollbar, not the direction, plus to keep the names aligned with other widgets, such as Slider.

I agree it's confusing, but at least there is no functional defect. If you don't object, I would tend to close this bug.
Comment 4 Stephan Leicht Vogt CLA 2011-10-27 07:32:57 EDT
What happens if the language is not a left-right-written language? In textfields this would switch the decrease/increase-direction and the icons would end up on the wrong side. Or doesn't it work that way?
Comment 5 Ivan Furnadjiev CLA 2012-07-17 03:29:54 EDT
(In reply to comment #3)
> I agree it's confusing, but at least there is no functional defect. If you don't
> object, I would tend to close this bug.
I will close this bug as suggested.