Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346603 - [Navigator View and Editor Sockets] Addition of the use of custom adapter factories in basic form editors
Summary: [Navigator View and Editor Sockets] Addition of the use of custom adapter fac...
Status: CLOSED FIXED
Alias: None
Product: Sphinx
Classification: Automotive
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Idrissa Dieng CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 04:28 EDT by Idrissa Dieng CLA
Modified: 2021-07-14 02:14 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Idrissa Dieng CLA 2011-05-20 04:28:31 EDT
Basic form editors should allows using custom adapter factories. Therefore, we should adapt the implementation of the org.eclipse.sphinx.emf.editors.forms.BasicTransactionalFormEditor#getAdapterFactory() method.
Comment 1 Idrissa Dieng CLA 2011-05-20 04:52:12 EDT
Fixed by adding:

- org.eclipse.sphinx.emf.editors.forms.BasicTransactionalFormEditor#getCustomAdapterFactory() method that return null by default.  Clients which want to use their own adapter factory that creates item providers which are specifically designed for the editor in which this form editor is used may override this method and return any adapter factory of their choice.

- modification of the org.eclipse.sphinx.emf.editors.forms.BasicTransactionalFormEditor#getAdapterFactory()
method like this:

public AdapterFactory getAdapterFactory() {
		EditingDomain editingDomain = getEditingDomain();
		AdapterFactory customAdapterFactory = getCustomAdapterFactory();
		if (customAdapterFactory != null) {
			return customAdapterFactory;
		} else if (editingDomain != null) {
			return ((AdapterFactoryEditingDomain) editingDomain).getAdapterFactory();
		}
		return null;
	}
Comment 2 Balazs Grill CLA 2021-07-14 02:14:46 EDT
Mass-closing Resolved tickets