Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346579 - [php5.3]add click for goto label
Summary: [php5.3]add click for goto label
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 01:21 EDT by Zhongwei Zhao CLA
Modified: 2020-05-14 11:35 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhongwei Zhao CLA 2011-05-20 01:21:31 EDT 
namespace a;
NSLABEL:
echo a;
GOTO NSLABEL;

when user click on the second NSLABEL,it should navigate to its declaration.
Comment 1 Michal Niewrzal CLA 2016-06-13 06:45:44 EDT 
Unnecessary improvement in my opinion.
Comment 2 Dawid Pakula CLA 2016-06-13 06:55:33 EDT 
On monster procedural code (more than 1k lines) might be very usable for navigation ;) Occurrence for matching labels also.
Comment 3 Laurent Lyaudet CLA 2017-11-24 08:10:27 EST 
Hello,
A sample file to test it works in and outside function scope ><
<?php

function foo($b){
  $a = null;
  if($b){
    goto bar;
  }

  //do something
  $a = 'a';

  bar:

  //do something
  $c = 'c';
  return [$a, $c];
}//fin fonction foo()


//do something
$b = true;

bar:
list($a, $c) = foo($b);

if($a === null){
  $b = false;
  goto bar;
}

var_dump($a);

?>

Best regards,
   Laurent Lyaudet
Comment 4 Thierry BLIND CLA 2017-11-27 13:32:41 EST 
https://git.eclipse.org/r/#/c/112352
Comment 5 Thierry BLIND CLA 2017-11-27 13:36:29 EST 
Merged.
Comment 7 Eclipse Genie CLA 2017-11-27 14:05:28 EST 
New Gerrit change created: https://git.eclipse.org/r/112352