Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346525 - [Tooling] Use stable URLs for runtime download
Summary: [Tooling] Use stable URLs for runtime download
Status: CLOSED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Releng (show other bugs)
Version: 1.4   Edit
Hardware: PC Linux
: P1 enhancement (vote)
Target Milestone: 1.4 RC2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 346521
Blocks: 346811
  Show dependency tree
 
Reported: 2011-05-19 14:49 EDT by Ralf Sternberg CLA
Modified: 2011-05-23 08:27 EDT (History)
1 user (show)

See Also:
rsternberg: review? (holger.staudacher)


Attachments
updates the repository URLs to the stable ones (1.33 KB, patch)
2011-05-20 05:45 EDT, Beyhan Veliev CLA
holger.staudacher: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2011-05-19 14:49:50 EDT
The RAP Tooling should download the runtime from the new stable URLs (see bug 346521).
Comment 1 Beyhan Veliev CLA 2011-05-20 05:45:12 EDT
Created attachment 196193 [details]
updates the repository URLs to the stable ones
Comment 2 Ralf Sternberg CLA 2011-05-21 07:47:05 EDT
(In reply to comment #1)
> Created attachment 196193 [details]
> updates the repository URLs to the stable ones

Beyhan, I think the following constants are no longer needed and should be removed, shouldn't they?

  private final static String TARGET_VERSION_LATEST_BUILD = "1.4"; //$NON-NLS-1$
  private final static String TARGET_VERSION_LATEST_RELEASE = "1.3"; //$NON-NLS-1$
Comment 3 Beyhan Veliev CLA 2011-05-22 09:00:57 EDT
(In reply to comment #2)
> (In reply to comment #1)
> Beyhan, I think the following constants are no longer needed and should be
> removed, shouldn't they?
> 
> private final static String TARGET_VERSION_LATEST_BUILD = "1.4"; //$NON-NLS-1$
> private final static String TARGET_VERSION_LATEST_RELEASE = "1.3";
> //$NON-NLS-1$
Not jet. I was waiting for our composite repositories to fix this. I thought there is a bug for this but I dind't find and I opened a new bug 346811. 
I will look at it this week.
Comment 4 Holger Staudacher CLA 2011-05-23 06:11:05 EDT
Beyhan, I reviewed your patch and modified some things. First of all the composite URLs are working. Second, I don't see that we should go with the version in the target name. If I install a target from our dialog e.g. the latest stable build I can receive an 1.4RC1 build. When I come back two month later and update my target I will get an 1.5M1 build. In this case the 1.4 will be still in the target name. 

To avoid this we decided to use this as target platform names:
RAP Runtime - latest stable build
RAP Runtime - latest release

This also marks bug 346811 as unnecessary and I will close this bug soon. 

I committed the patch to CVS HEAD and the 1.4 maintenance branch.

Thanks for the work.