Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346518 - weaving hook support creates an extra byte[] copy each class load when it is not necessary
Summary: weaving hook support creates an extra byte[] copy each class load when it is ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 348770
Blocks:
  Show dependency tree
 
Reported: 2011-05-19 14:10 EDT by Thomas Watson CLA
Modified: 2011-06-30 12:13 EDT (History)
0 users

See Also:

Attachments
patch (3.43 KB, patch)
2011-05-19 17:24 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2011-05-19 14:10:33 EDT 
In org.eclipse.osgi.internal.baseadaptor.weaving.WeavingHookConfigurator.processClass(String, byte[], ClasspathEntry, BundleEntry, ClasspathManager) there is a call to org.eclipse.osgi.internal.baseadaptor.weaving.WovenClassImpl.setHooksComplete() which I think is unnecessary and results in an extra byte[] copy for each class load.
Comment 1 Thomas Watson CLA 2011-05-19 17:24:24 EDT 
Created attachment 196172 [details]
patch
Comment 2 Thomas Watson CLA 2011-06-30 12:13:29 EDT 
Patch released for 3.7.1.