Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346505 - [PropertyView] EReference selection dialogs should use the service edit for filtering allowed types
Summary: [PropertyView] EReference selection dialogs should use the service edit for f...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Camille Letavernier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 12:40 EDT by Yann Tanguy CLA
Modified: 2011-07-01 08:42 EDT (History)
1 user (show)

See Also:

Attachments
Patch (1/2) (6.74 KB, patch)
2011-05-19 12:41 EDT, Yann Tanguy CLA 		no flags Details | Diff
Patch (2/2) (2.64 KB, patch)
2011-05-19 12:42 EDT, Yann Tanguy CLA 		no flags Details | Diff
Integration of the previous patches in the current framework (7.35 KB, patch)
2011-05-23 08:18 EDT, Camille Letavernier CLA 		vincent.lorenzo: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Tanguy CLA 2011-05-19 12:40:57 EDT 
EReference selection dialogs should use the service edit for filtering allowed types.
Comment 1 Yann Tanguy CLA 2011-05-19 12:41:34 EDT 
Created attachment 196136 [details]
Patch (1/2)
Comment 2 Yann Tanguy CLA 2011-05-19 12:42:24 EDT 
Created attachment 196137 [details]
Patch (2/2)
Comment 3 Yann Tanguy CLA 2011-05-19 12:45:40 EDT 
A possible implementation patch added (still requires clean up and testing).

To test :
- create a BDD with a Block
- add a FlowPort on the Block 
- try to set the type of the FlowPort

The dialog should only show allowed types (Signal, Block, FlowSpecification, DataType and ValueType) whereas using current implementation, every kind of UML Type is visible.
Comment 4 Camille Letavernier CLA 2011-05-23 08:18:52 EDT 
Created attachment 196323 [details]
Integration of the previous patches in the current framework

This patch is an integration of the previous two patches from Yann Tanguy, in order to make the dialog compatible with the one from https://bugs.eclipse.org/bugs/show_bug.cgi?id=340430

The previous two patches are now deprecated.
Comment 5 Vincent Lorenzo CLA 2011-05-23 08:35:11 EDT 
Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. 
I've committed this contribution.
Committed revision 4755.
Comment 6 Vincent Lorenzo CLA 2011-05-23 09:07:56 EDT 
Comment on attachment 196323 [details]
Integration of the previous patches in the current framework

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. 
I've committed this contribution.
Committed revision 4755.
Comment 7 Camille Letavernier CLA 2011-07-01 08:42:52 EDT 
Done in Indigo