Community
Participate
Working Groups
The ant task is not filtering problems as it should. I believe the ant task should not check the equality of the resource path in the reported problem. When running the ant task on binary, there is no such thing as a resource path for the corresponding problem. If the id, problem arguments and type name are matching, then the problem should be filtered.
Daniel, this is the issue that is causing the pb with the current reports.
Created attachment 196134 [details] Proposed fix The fix is to use a specific method to match the filtered problem and the reported problem inside the ant api filter store. I also wonder how api usage issues are properly filtered for the same reason. But given the time of the change, I would only focus on fixing that specific issue.
Michael, please review.
Curtis, please review.
+1 Debugging through the task it is clear that the filters don't apply because the resource doesn't match. The fix corrects this, just checking the type name.
+1 looks fine
Daniel, if you want the fix for RC3, you will need to provide a +1 as well.
Can you explain why it worked up to RC1 (actually even RC2-I20110518-0800) but now we see those issues since I20110519-0800, e.g. http://download.eclipse.org/eclipse/downloads/drops/I20110519-1138/apitools/apitoolsverifications/html/index.html?
I20110518-0800 was not using RC1 api tools bundles. Previous versions missing some problems and could not filter right others. The patch is pretty straight forward and I ran a test successfully with it.
The fix looks good.
Released for 3.7RC3.
Released.
(In reply to comment #12) > Released. That's not what I see: I see the code is *committed* to HEAD but it does not seem to be released (Team > Release) into the builds.
Verified in I20110525-0800.
