Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346399 - [client] Show "object" commands only in chosen "doms"
Summary: [client] Show "object" commands only in chosen "doms"
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Szymon Brandys CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 05:11 EDT by Szymon Brandys CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-05-19 05:11:56 EDT 
On the git log page there are two lists. One is for commits, the other is for diffs in the selected commit. 

When there are "object" commands contributed to the command framework, the commands are shown on both lists. The visibility of "object" commands relies on JSONs passed to the "visibleWhen" method. Right now, I had to add a check for the "committerName" field in JSON to control on which list the "object" command should be shown.
Comment 1 Szymon Brandys CLA 2011-05-19 08:07:40 EDT 
Fixed with cce0f089b2efd551d3f5fbf7c37b72029efa845e.