Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346348 - selecting an EAR and creating a module, does not pre-fills the wizard with the EAR Name.
Summary: selecting an EAR and creating a module, does not pre-fills the wizard with th...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Israel Gomez Delgado CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 17:44 EDT by Israel Gomez Delgado CLA
Modified: 2011-06-23 11:36 EDT (History)
3 users (show)

See Also:
cbridgha: review+

Attachments
This Patch pre-sets the selected EAR name in the wizard (6.52 KB, patch)
2011-05-18 18:01 EDT, Israel Gomez Delgado CLA 		no flags Details | Diff
Corrected Patch (7.12 KB, patch)
2011-05-19 10:46 EDT, Israel Gomez Delgado CLA 		ccc: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Israel Gomez Delgado CLA 2011-05-18 17:44:27 EDT 
Build Identifier: WTP 3.2.4

creating a module (as DWP or EJB) when you select an EAR. The ear that is specified by default in the wizard is not the ear that was selected, when you have EARs of different versions in your workspace, the EAR with the higher version is the one specified.

Reproducible: Always

Steps to Reproduce:
1.Create an EAR of version 1.4.
1.Create an EAR of version 5.
2.Select the EAR 1.4 and create a module (as DWP or EJB) when you select an EAR. The ear that is specified by default in the wizard is not the EAR that was selected.
Comment 1 Israel Gomez Delgado CLA 2011-05-18 18:01:22 EDT 
Created attachment 196053 [details]
This Patch pre-sets the selected EAR name in the wizard
Comment 2 Chuck Bridgham CLA 2011-05-19 09:28:24 EDT 
approve
Comment 3 Chuck Bridgham CLA 2011-05-19 10:13:16 EDT 
Isreal - Roberto helped me review these changes.. and caught a couple issues

When setting a property, normally it is not necessary to add a property change event because this is called as part of the set....

+		    j2eeModel.setProperty(IJ2EEModuleFacetInstallDataModelProperties.EAR_PROJECT_NAME, earName);
+		    j2eeModel.notifyPropertyChange(IJ2EEModuleFacetInstallDataModelProperties.EAR_PROJECT_NAME, IDataModel.VALID_VALUES_CHG);



And...  can you fix the spelling error:   "getSlection()"
Comment 4 Israel Gomez Delgado CLA 2011-05-19 10:46:04 EDT 
Created attachment 196118 [details]
Corrected Patch
Comment 5 Chuck Bridgham CLA 2011-06-10 10:55:57 EDT 
approved
Comment 6 Roberto Sanchez Herrera CLA 2011-06-13 15:57:51 EDT 
The second, corrected patch was committed to R3_2_maintenance for WTP 3.2.5. I will keep this defect open to until branch for 3.3.1 is available to commit to 3.3.1 and HEAD
Comment 7 Roberto Sanchez Herrera CLA 2011-06-23 11:20:57 EDT 
Committed to HEAD. That will cover WTP 3.3.1 and 3.4