Community
Participate
Working Groups
This bug is used to track the Salvo GSoC project 2011. It is used to track various discussions that will otherwise get lost in space. http://wiki.eclipse.org/Google_Summer_of_Code_2011_Ideas/ECF_Salvo
[19:45:28] Isuru Udana: i want some clarification on the reply you sent [19:45:37] Isuru Udana: "So, the question is, can the registration of the Eclipse ID go from the project? The answer is no. Please note that Salvo already has a user/pass store, you can leverage this code." [19:45:37] Wim Jongman: sure [19:45:51] Isuru Udana: can please explain me that part [19:45:57] Wim Jongman: what part? [19:46:06] Wim Jongman: the first or the last [19:46:14] Isuru Udana: "So, the question is, can the registration of the Eclipse ID go from the project? The answer is no. Please note that Salvo already has a user/pass store, you can leverage this code." [19:46:17] Isuru Udana: this part [19:46:54] Wim Jongman: About if the bugzilla registration can go from the GSoC project? [19:47:12] Wim Jongman: or the use of the Salvo user/pass store [19:48:11] Isuru Udana: so you mean we can't use the bugzilla userId, password for posting from salvo [19:48:29] Wim Jongman: No [19:49:08] Wim Jongman: You asked if the registration of users still was important because we could use the "exquistus" user [19:50:03] Isuru Udana: yes. i had that question [19:50:33] Wim Jongman: the answer is: We always post with the official Eclipse ID of the user. [19:50:45] Wim Jongman: We cannot use exquisitus [19:50:50] Wim Jongman: exquisitus is evil [19:51:00] Isuru Udana: thats true. [19:51:08] Wim Jongman: ;) [19:51:35] Isuru Udana: but I cannot log in from my bugzilla userId from Salvo [19:51:38] Isuru Udana: why is that? [19:51:56] Wim Jongman: what is your bugzilla user id? [19:52:07] Isuru Udana: isudana@gmail.com [19:52:17] Wim Jongman: can you post bugs with it? [19:52:24] Isuru Udana: yes I can [19:52:40] Wim Jongman: you should be able to login in salvo with it. [19:52:59] Isuru Udana: ok. i will have a try again [19:53:04] Wim Jongman: I use my bugzilla account [19:55:08] Isuru Udana: what is the operating system you recommend me to development? [19:55:40] Isuru Udana: I use Ubuntu. But I feel some of the errors occur running salvo is due to the OS [19:59:53] Wim Jongman: Yes, use ubuntu. That is just fine. Is Salvo working okay on ubuntu? [20:00:18] Wim Jongman: What problems do you have? [20:01:50] Isuru Udana: i think there is some problem with secure storage [20:02:13] Wim Jongman: Yes that could be. I found the same thing on ubunut [20:02:14] Isuru Udana: you may remember the bug I reported last time [20:02:41] Isuru Udana: its due to the secure storage [20:03:14] Wim Jongman: Ah, yes.. I will try to fix that. But first I am going to create a build for the Salvo product [20:03:29] Isuru Udana: without secure storage that problem is not occuring [20:03:36] Wim Jongman: I see. [20:03:46] Wim Jongman: Did you already made some changes to Salvo? [20:04:00] Isuru Udana: No. [20:04:28] Wim Jongman: Remember that a lot of the stuff is already there for you to use. [20:04:41] Wim Jongman: Like the perspective and stuff [20:05:15] Isuru Udana: yes. creating a perspective is not a big thing AFAIK [20:05:23] Wim Jongman: Can you also provide your report for last week? http://wiki.eclipse.org/Newsreader/Salvo_UI_Integration_in_the_workbench#Project_Administration [20:05:33] Isuru Udana: ok [20:06:00] Wim Jongman: Shall we hold a conference again next sunday? [20:06:12] Isuru Udana: ok [20:06:26] Isuru Udana: btw did you look at the timeline [20:06:53] Isuru Udana: i am not sure about the extact dates i put. [20:07:46] Wim Jongman: Yes, lets discuss this on Sunday. [20:07:53] Isuru Udana: ok
Hi Wim, Can you please have look at my work and give a feedback. If the current implementation is OK for now, we can move to start working the "digest view" functionality. And I have file several bugs in Salvo. Please have a look at them also. Thank you -- Regards, Isuru Udana
Discussion after finishing the "Ask A Question" part: hi [10:10:35] Wim Jongman: hi isuru [10:10:56] Isuru Udana: for this bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=347350 [10:11:15] Isuru Udana: what p2 bundles should i remove in the launch config? [10:11:21] Wim Jongman: all [10:11:49] Wim Jongman: and then do add dependend plugins button [10:12:01] Wim Jongman: or whatever it is called [10:14:10] Isuru Udana: you mean bundles like org.eclipse.equinox.p2.discovery should be removed from the launch config ? [10:14:24] Wim Jongman: yes, all bundles with p2 in the name [10:14:58] Wim Jongman: and then press the add required plug-ins button [10:16:09] Isuru Udana: i cannot find that button [10:16:42] Wim Jongman: it is there [10:16:53] Isuru Udana: i am in the Plu-ins tab of the Run configurations [10:16:58] Wim Jongman: yes [10:17:20] Isuru Udana: got it [10:17:47] Isuru Udana: when i filtered using p2 that button was hidden [10:17:49] Wim Jongman: don't tell me you have never used that before [10:18:03] Wim Jongman: ah, i see. ;) [10:18:07] Isuru Udana: :) [10:19:05] Wim Jongman: can you rebase with my repository and make a pull request for the add a questin wizard? [10:19:25] Wim Jongman: I have fixed some bugs [10:19:38] Isuru Udana: i rebased it yesterday [10:19:40] Wim Jongman: did you get those already? [10:19:44] Isuru Udana: yes [10:19:46] Wim Jongman: excellent! [10:19:55] Isuru Udana: i checked those and worked fine [10:20:11] Isuru Udana: shall I sent a pull request? [10:20:49] Wim Jongman: nice. Good catch with the race condition. I did not understand with what you meant "the screen goes black" but this is something that happens on ubuntu and not in windows [10:21:03] Wim Jongman: please do sent a pull request [10:21:25] Isuru Udana: ok [10:27:27] Isuru Udana: have a question regarding Git [10:28:15] Wim Jongman: I probably cannot help you there but shoot [10:29:23] Isuru Udana: To update with the original repository, what i did was fetching and merging [10:29:36] Isuru Udana: is it the correct way ? [10:29:46] Wim Jongman: I think it is. I am not sure. [10:29:56] Isuru Udana: it worked fine and i got all the updated chages [10:30:08] Wim Jongman: then this is the way [10:30:16] Isuru Udana: i sent a pull request [10:30:24] Wim Jongman: thanks, I will fetch it. [10:30:31] Isuru Udana: thanks [10:31:10] Isuru Udana: i did some modifications. did you look those changes ? [10:31:22] Wim Jongman: no, i did not see them yet [10:31:29] Isuru Udana: ok [10:32:05] Isuru Udana: I removed all the bad things I have done in the wizard [10:32:43] Isuru Udana: added the search bar and changed the image descriptor [10:33:44] Isuru Udana: i creates images by myself by doing some photo editing since we cannot use others images. [10:34:01] Wim Jongman: Nice. [10:34:09] Wim Jongman: Salvo is building your changes: [10:34:10] Wim Jongman: https://build.ecf-project.org/jenkins/job/C-HEAD-salvo.feature/ [10:37:43] Wim Jongman: You must add a comment like this on the start if every class: [10:37:45] Wim Jongman: /******************************************************************************* * Copyright (c) 2010 Weltevree Beheer BV, Remain Software & Industrial-TSI * * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at * http://www.eclipse.org/legal/epl-v10.html * * Contributors: * Wim Jongman - initial API and implementation *******************************************************************************/ [10:38:10] Isuru Udana: ok. i will [10:38:17] Wim Jongman: The first line can be: Copyright (c) 2011 University of .... [10:38:34] Wim Jongman: and add your name as contributor [10:38:45] Isuru Udana: ok. thank you [10:39:52] Wim Jongman: Another thing to be aware of: [10:40:07] Wim Jongman: Add javadoc. [10:40:20] Wim Jongman: At least for classes that are not in *internal* packages [10:40:29] Wim Jongman: these are our API [10:40:35] Isuru Udana: ok. i will [10:41:20] Wim Jongman: Do not use System.out.println [10:41:21] Wim Jongman: https://github.com/isudana/Newsreader/blob/618cf9b2e980cacf652ea4df9464c0acad2cd78c/bundles/org.eclipse.ecf.salvo.ui/src/org/eclipse/ecf/salvo/ui/wizards/AskAQuestionWizard.java [10:41:33] Wim Jongman: but use the Salvo debug mechanism [10:41:47] Wim Jongman: -Dsalvo.debug=true [10:42:09] Isuru Udana: ok [10:42:29] Wim Jongman: Debug.log(getClass(), e); Debug.log(getClass(), "I want to log this"); [10:42:55] Wim Jongman: instead of println [10:43:33] Isuru Udana: ok. i will figure it out. I forgot to erase that dummy code [10:43:55] Wim Jongman: Also do not use e.printStackTrace() [10:44:14] Wim Jongman: Do something with the exception [10:44:19] Wim Jongman: log it, swallow it or rethrow it [10:44:35] Isuru Udana: ok [10:45:15] Wim Jongman: See the same class for an example of the exceptions that are not dealt with [10:45:48] Wim Jongman: I like your programming style [10:45:52] Wim Jongman: It is nice and clean [10:45:58] Isuru Udana: thank you [10:46:23] Isuru Udana: i was bit worried whether you like my programing style [10:46:32] Isuru Udana: big relief :) [10:47:01] Wim Jongman: haha [10:47:18] Wim Jongman: When I see things I will point it out to you. [10:47:29] Isuru Udana: please do [10:47:36] Isuru Udana: that will help me a lot [10:47:55] Wim Jongman: ok. can you fix the things I have pointed out? [10:48:04] Isuru Udana: yes. i will [10:48:17] Isuru Udana: thank you very much for the valueble comments [10:49:20] Wim Jongman: The build has completed: I am now updating the new Salvo in my workbench [10:50:38] Wim Jongman: Can you try to create the function to fetch all articles that this user has created or that this user has replied to? [10:51:05] Isuru Udana: yes. I am thinking of doing that [10:51:40] Wim Jongman: I think a good place for this method is somewhere in the ServerStoreFacade [10:53:03] Wim Jongman: this Facade pattern combines two or more separate interfaces into one convenient overall class [10:53:36] Wim Jongman: This is what I tried to do with this class. [10:53:50] Wim Jongman: It tries to negotiate between the Store and the Server. [10:54:14] Wim Jongman: Sometimes we need to fetch articles from the Server and sometimes we need to fetch it from the Store [10:54:23] Isuru Udana: yes [10:55:09] Wim Jongman: In order to avoid stuff like: if(article is in store) fetch from store else{ fetch from server put in store } [10:55:29] Wim Jongman: we program a facade to hide this complexity [10:55:38] Isuru Udana: got it [10:56:12] Wim Jongman: so we can say in our code IServerStoreFacade.getarticles [10:56:26] Wim Jongman: and let the facade class deal with the complexity [10:56:36] Isuru Udana: ok [10:57:28] Wim Jongman: see the ServerStoreFacade.getArticles(newsgroup, int, int) method [10:57:56] Wim Jongman: in the article. there is a isMine() method [11:00:41] Isuru Udana: great [11:00:52] Isuru Udana: then we do it easily [11:01:18] Isuru Udana: *we can [11:02:08] Isuru Udana: i will read the code further and implement it [11:02:45] Wim Jongman: Yes but be carefull to use the store so that you do not run thru 10000 articles to find all isMine() is true [11:03:23] Wim Jongman: Also, investigate the nntp protocol to see if there is something there do query the server for all my articles. [11:03:34] Wim Jongman: do = to [11:03:34] Isuru Udana: ok. i will [11:05:19] Wim Jongman: okay, thank. I will add this discussion to the GSoC bug
Discussion of may 10 [9-5-2011 10:14:46] Isuru Udana: hi [9-5-2011 10:17:46] Wim Jongman: Hi Isuru [9-5-2011 10:18:17] Isuru Udana: just to give you a update on what im doing these days [9-5-2011 10:18:49] Isuru Udana: im looking in to create bugzilla id from workbench thing [9-5-2011 10:19:08] Isuru Udana: We can easily do it in mylyn way [9-5-2011 10:19:33] Isuru Udana: in mylyn they are just opening a link in the web browser [9-5-2011 10:19:58] Wim Jongman: Ok. That sounds easy.. Nice [9-5-2011 10:20:07] Isuru Udana: yeah [9-5-2011 10:20:19] Isuru Udana: but i am thinking of doing it in a better way [9-5-2011 10:20:34] Wim Jongman: what is your idea? [9-5-2011 10:20:58] Isuru Udana: Bugzilla has RPC support [9-5-2011 10:22:09] Wim Jongman: Bugzilla also has REST support [9-5-2011 10:23:02] Wim Jongman: https://wiki.mozilla.org/Bugzilla%3aREST_API [9-5-2011 10:23:17] Isuru Udana: http://www.bugzilla.org/docs/3.0/html/api/Bugzilla/WebService/User.html [9-5-2011 10:23:52] Isuru Udana: but the api is still in experimental stage [9-5-2011 10:25:34] Isuru Udana: i tried to access Eclipse bugzilla from a sample code available in the web [9-5-2011 10:25:52] Wim Jongman: did not work? [9-5-2011 10:26:01] Isuru Udana: yeah didnt work [9-5-2011 10:26:08] Isuru Udana: for Mozilla it worked [9-5-2011 10:26:29] Isuru Udana: Need to do some research [9-5-2011 10:26:56] Isuru Udana: in mylyn they are accessing eclipse bugzilla using same machanism [9-5-2011 10:27:01] Isuru Udana: XML-RCP [9-5-2011 10:30:11] Wim Jongman: Ah, ok. Well, for the creation of an account I would not worry too much about the technology used to get into bugzilla. [9-5-2011 10:30:20] Wim Jongman: I would choose the simplest safe method. What is important is the plugin that represents the UI in Eclipse. [9-5-2011 10:30:46] Wim Jongman: I would create two separate plugins for this. *.*.*.account.core and *.*.*.account.ui. The UI would be in the preference page of Eclipse under the General tab. [9-5-2011 10:31:37] Wim Jongman: It would be nice if this is extensible. [9-5-2011 10:32:16] Wim Jongman: So that other parties can also add their accounts to this preference page. [9-5-2011 10:32:40] Isuru Udana: ok [9-5-2011 10:33:47] Isuru Udana: so do you think its better to go with mylyns way ? [9-5-2011 10:34:21] Wim Jongman: If this is the simplest and fastest method then yes. [9-5-2011 10:34:36] Isuru Udana: yes. it is [9-5-2011 10:35:30] Wim Jongman: so if you create the basic account management in the plugins I described then You can add another plugin to hook Eclipse bugzilla into this mechanism. [9-5-2011 10:35:36] Wim Jongman: Does this make any sense to you? [9-5-2011 10:36:17] Isuru Udana: no. i need further clarification [9-5-2011 10:37:00] Wim Jongman: Okay. Thank you. It is important that you always tell me if you don't understand. [9-5-2011 10:37:19] Wim Jongman: We can go two ways: [9-5-2011 10:38:09] Wim Jongman: 1. We can make a quick and specialized account creation mechanism for our purpose and be done with it. Or... [9-5-2011 10:38:37] Wim Jongman: 2. Make a general account management mechanism. And we hook into that. [9-5-2011 10:38:48] Isuru Udana: i got the point [9-5-2011 10:40:18] Isuru Udana: then we'll allow other bugzilla account creation other than Eclipse bugzilla? [9-5-2011 10:41:19] Wim Jongman: Exactly. Other parties maybe also want to use your GSoC programs to integrate with the workbench. [9-5-2011 10:41:52] Wim Jongman: So we would need a UI to represent the accounts in the workbench. [9-5-2011 10:42:32] Wim Jongman: and a CORE to retrieve account information from the local secure preferences. [9-5-2011 10:43:13] Wim Jongman: Then we can add a third plugin that hooks into these two and provides Eclipse Bugzilla credentials. [9-5-2011 10:44:57] Isuru Udana: but in the mylyn account creation way. We have no clue of whether the account is actually created or not. Because account creation happen in the web browser. [9-5-2011 10:45:36] Wim Jongman: We can program around this, can't we? Like first try to create the accound and then login to see if it is active. [9-5-2011 10:46:20] Wim Jongman: If you want to use RPC that is fine with me. We can always make a better implementation because we have decoupled the code. [9-5-2011 10:46:51] Isuru Udana: i will try to find the best possible way [9-5-2011 10:47:11] Wim Jongman: Okay, do you now get the idea of account management option 2? [9-5-2011 10:48:07] Isuru Udana: yes. but one question [9-5-2011 10:48:41] Wim Jongman: shoot [9-5-2011 10:48:59] Isuru Udana: what do we need to provide other than account creation in account management [9-5-2011 10:49:15] Isuru Udana: change account preferences? [9-5-2011 10:51:57] Wim Jongman: That is something we need to talk about. If we want to make this a general API, then we can also ask the community by filing a bug against platform. [9-5-2011 10:52:51] Wim Jongman: I would think we need an extension point that provides a interface to check and create an account [9-5-2011 10:53:24] Isuru Udana: ok i will continue my research and ask questions from you where neccessary. [9-5-2011 10:53:48] Wim Jongman: Maybe also including a map that allows the user to store additional information like address and email [9-5-2011 10:54:25] Isuru Udana: i will first create a simple plugin to try out mylns way of account creation. [9-5-2011 10:54:51] Wim Jongman: Okay. sounds good. [9-5-2011 10:55:11] Isuru Udana: then let's discuss on this futher [9-5-2011 10:55:35] Isuru Udana: i just want to make sure im on the right track and update you [9-5-2011 10:57:13] Isuru Udana: Another thing. do you think i should post weekly updates to soc-dev mailing list. In the last week i post a one. but no one else out of 16 other gsoc students did :) [9-5-2011 11:00:39] Wim Jongman: I like it. Maybe you can write your reports on the wiki and then just send out a link to the wiki to the list [9-5-2011 11:01:00] Isuru Udana: ok. [9-5-2011 11:01:04] Isuru Udana: thanks [9-5-2011 11:01:19] Isuru Udana: have a nice day. bye [9-5-2011 11:01:28] Wim Jongman: you too! Bye.
Sunday May 22 2011 [22-5-2011 7:55:39] Isuru Udana: hi [22-5-2011 9:49:37] Isuru Udana: hi [22-5-2011 14:28:59] Isuru Udana: hi [22-5-2011 17:44:24] Wim Jongman: hi [22-5-2011 18:42:56] Isuru Udana: hi [22-5-2011 18:43:09] Wim Jongman: hi [22-5-2011 18:44:11] Isuru Udana: im thinking of start the actual implementation of "Creating Bugzilla user from workbench" [22-5-2011 18:44:24] Wim Jongman: Alright. [22-5-2011 18:44:58] Isuru Udana: but i wonder hows that bug effects our project [22-5-2011 18:45:20] Wim Jongman: It will be useful anyhow [22-5-2011 18:45:28] Isuru Udana: yes thats true [22-5-2011 18:45:37] Isuru Udana: so i will go ahead [22-5-2011 18:45:42] Wim Jongman: Yes. Please do. [22-5-2011 18:45:46] Isuru Udana: i need some clarifications [22-5-2011 18:45:51] Wim Jongman: ok shoot [22-5-2011 18:46:33] Isuru Udana: what kind of a UI should i provide to users to create bugzilla id ? [22-5-2011 18:47:04] Isuru Udana: once you have mentioned to place it in the preference page [22-5-2011 18:47:23] Isuru Udana: is that the way to go ? or shall we place it in the menu ? [22-5-2011 18:47:56] Isuru Udana: i feel if we put that in the preference no will get noted of that feature [22-5-2011 18:48:30] Wim Jongman: Well, the UI can go anywhere. We can put it in a menu AND in the preference page. I think there is a wizard first to create the account and then the menu option and/or the preference page to maintain it. [22-5-2011 18:49:12] Isuru Udana: ok [22-5-2011 18:50:17] Isuru Udana: i will first create the account creation feature [22-5-2011 18:50:39] Isuru Udana: i will try to make it extensible as you mentioned [22-5-2011 18:51:21] Isuru Udana: i though of exposing a extension point. so that others can hook their bugzilla accounts to it [22-5-2011 18:52:10] Wim Jongman: bugzilla and other systems. Does not need to be bugzilaa [22-5-2011 18:52:13] Isuru Udana: today i went though some articles on creating extension points and tried out some samples as I havent done that before [22-5-2011 18:53:08] Wim Jongman: You should be able to do that. It is not the hardest part of Eclipse development. If you have problems please let me know. [22-5-2011 18:53:23] Isuru Udana: ok [22-5-2011 18:54:02] Isuru Udana: but i have a doubt whether we can create a common plugin for creating all the account systems. [22-5-2011 18:55:43] Wim Jongman: It must be a general callback to create an account. But leave the extension point for the last. This is just icing on the cake. [22-5-2011 18:56:07] Wim Jongman: Let's first create the UI and then look at the inspriration we get from that. [22-5-2011 18:56:21] Isuru Udana: ok that's good [22-5-2011 18:57:39] Isuru Udana: have you look at my time line ? [22-5-2011 18:59:05] Isuru Udana: i am not sure I can stick to the exact dates. is that going to be a big problem ? [22-5-2011 18:59:42] Wim Jongman: What do you mean by that? [22-5-2011 19:00:55] Isuru Udana: i mean, if we come across unexpected issues in the development process, there may be changes in the tasks/timeline [22-5-2011 19:01:02] Isuru Udana: then will that going to be a problem ? [22-5-2011 19:01:52] Wim Jongman: No really. The most important tasks are m1, m4 and m5. Please do these things first. [22-5-2011 19:03:20] Isuru Udana: but i though we should do M2 first before doing M5 [22-5-2011 19:04:43] Wim Jongman: Yes, M2 and M3 can be combined. They should go first but this is just a matter of installing the plugins right? [22-5-2011 19:05:05] Isuru Udana: yeah. its a simple task [22-5-2011 19:05:06] Wim Jongman: Everything else is already there [22-5-2011 19:05:18] Isuru Udana: true [22-5-2011 19:05:24] Wim Jongman: you have 20 days for m3 [22-5-2011 19:05:37] Isuru Udana: ahh thats too much [22-5-2011 19:05:41] Isuru Udana: i will change that [22-5-2011 19:05:59] Wim Jongman: ok [22-5-2011 19:07:25] Isuru Udana: do you think we can overcome from that bug quickly ? [22-5-2011 19:08:14] Wim Jongman: if not then we will use the exquisitus account. The create bugzilla account will be nice for many more projects [22-5-2011 19:08:37] Isuru Udana: yes. [22-5-2011 19:09:51] Isuru Udana: ok. i will contact you again if I got problems. So first I will create a sample UI creating user accounts [22-5-2011 19:11:30] Wim Jongman: ok, here is the bugzilla API: http://www.bugzilla.org/docs/tip/en/html/api/Bugzilla/WebService/User.html [22-5-2011 19:11:41] Wim Jongman: maybe you can use that [22-5-2011 19:12:15] Isuru Udana: that's XML-RCP [22-5-2011 19:13:34] Isuru Udana: I tried to use this before and failed [22-5-2011 19:14:12] Isuru Udana: And for account creation you suggests me to use the simplest method. [22-5-2011 19:14:38] Isuru Udana: that is opening the link from the web browser [22-5-2011 19:15:16] Wim Jongman: so what is this UI then that you talk about? [22-5-2011 19:16:26] Isuru Udana: I am thinking of creating a wizard and in that wizard we can list out currently available account types. [22-5-2011 19:17:26] Wim Jongman: Did you already make a design for it? [22-5-2011 19:17:45] Isuru Udana: list is generated from contributors of the exposed extension point [22-5-2011 19:18:01] Isuru Udana: No. it's my idea [22-5-2011 19:18:24] Isuru Udana: please suggests me a better one if you have [22-5-2011 19:21:44] Wim Jongman: Please make a short design an post that to the list. [22-5-2011 19:22:08] Wim Jongman: So put your ideas on paper so we can discuss this. [22-5-2011 19:22:47] Wim Jongman: Or better, put it on the wiki. We need to have some kind of document otherwise we will keep going from left to right [22-5-2011 19:23:03] Isuru Udana: ok thats good [22-5-2011 19:24:21] Isuru Udana: ok will do that and contact you [22-5-2011 19:24:26] Isuru Udana: thank you [22-5-2011 19:25:29] Wim Jongman: I like the extension point idea but we don't want to tie it to bugzilla only right? [22-5-2011 19:25:37] Wim Jongman: be creative. [22-5-2011 19:26:40] Isuru Udana: i will try my best. and i want to create a nice product somehow [22-5-2011 19:27:18] Isuru Udana: thanks for you time. seems like you are very bussy these days [22-5-2011 19:27:33] Isuru Udana: good night
[20-6-2011 16:30:00] Isuru Udana: hi [20-6-2011 16:39:41] Wim Jongman: hi [20-6-2011 16:44:05] Isuru Udana: i thought showing 'this user articles' in the wizard is to give user a chance to see before he posting to a specific newsgroup [20-6-2011 16:46:15] Isuru Udana: for that i think showing the view after finishing wizard is not suitable [20-6-2011 16:46:46] Isuru Udana: WDYT ? Please correct me if i am in a wrong idea [20-6-2011 16:47:18] Wim Jongman: Yes, i see. I don't have problems with this dialog. You can leave it in but we need to find something really nice for the digest view. [20-6-2011 16:47:42] Isuru Udana: yes yes. this is totaly different from digest view [20-6-2011 16:47:58] Wim Jongman: Well, not totally. [20-6-2011 16:48:18] Wim Jongman: the digest view must also be able to show this kind of information. [20-6-2011 16:48:23] Isuru Udana: digest view is a superset of this [20-6-2011 16:48:26] Wim Jongman: yes. [20-6-2011 16:48:51] Wim Jongman: Did you also implement the new function on the filesystem database? [20-6-2011 16:49:15] Isuru Udana: no i just did it to derby [20-6-2011 16:49:25] Wim Jongman: okay, i will take a look at it. [20-6-2011 16:49:36] Isuru Udana: thank you [20-6-2011 16:49:54] Isuru Udana: did you look at how i have done it in derby ? [20-6-2011 16:50:52] Isuru Udana: please review it. I think it is very important before we start implementing the digest view UI [20-6-2011 16:52:04] Wim Jongman: i will take a look this evening [20-6-2011 16:52:12] Isuru Udana: ok [20-6-2011 16:53:11] Wim Jongman: The dialog is not showing correct results. If you have a reply on a topic, it only shows the reply not the main topic. Is it supposed to be a tree where you see replies on topics? [20-6-2011 16:53:38] Isuru Udana: that's true [20-6-2011 16:53:59] Isuru Udana: it's only showing what the user has posted [20-6-2011 16:54:52] Wim Jongman: isn;t the context important? [20-6-2011 16:55:00] Wim Jongman: If i have posted a topic AND a reply on that topic, I only see the reply [20-6-2011 16:55:50] Isuru Udana: the topic and the reply will shown as two different item [20-6-2011 16:56:02] Isuru Udana: ok. will take them in to a tree [20-6-2011 16:56:16] Isuru Udana: like what you have done in editorpanel [20-6-2011 16:56:46] Wim Jongman: don't spent too much time because it is not a part of the project. Please do the other stuff first and we can look at this later [20-6-2011 16:56:58] Isuru Udana: ok. [20-6-2011 16:56:59] Wim Jongman: leave it as it is for now [20-6-2011 16:57:53] Isuru Udana: ok. i went through the articlePanel code as it will be required in the future [20-6-2011 16:58:09] Isuru Udana: i didn't understand some parts totaly [20-6-2011 16:59:35] Isuru Udana: I can see in the ArticlePanel there are some unimplemented UI components. (Few buttons with name "New Item") [20-6-2011 16:59:57] Isuru Udana: what do you plan to do to them? [20-6-2011 17:00:03] Wim Jongman: Yes, it tries to lazy load history [20-6-2011 17:00:22] Wim Jongman: that code stinks and needs some love [20-6-2011 17:00:59] Isuru Udana: sorry. i didn't get that [20-6-2011 17:01:16] Wim Jongman: re: articlePanel [20-6-2011 17:01:43] Wim Jongman: you mean where the articles are loaded by the lazy loading mechanism [20-6-2011 17:02:36] Isuru Udana: "that code stinks and needs some love" [20-6-2011 17:03:45] Wim Jongman: yes, the loading of the articles in the article panel. The part when you scroll down and automatically fetches a next batch of articles stinks (is not good code) and needs some love (needs to be worked on) [20-6-2011 17:04:05] Isuru Udana: ok. got it :) [20-6-2011 17:05:24] Isuru Udana: ok. please review the derby functionality and give me a feeback when you have time. [20-6-2011 17:05:30] Isuru Udana: thank you. [20-6-2011 17:05:34] Isuru Udana: have a nice day [5-7-2011 13:43:06] Wim Jongman: Hi Isuru, everything ok? [29-7-2011 16:39:36] Isuru Udana: Did you look at my last email ? [29-7-2011 16:40:41] Wim Jongman: Yes. [29-7-2011 16:40:48] Wim Jongman: How many bundles are there in Mylyns common? [29-7-2011 16:41:15] Wim Jongman: Can we axtract just the notification bundle? [29-7-2011 16:41:18] Isuru Udana: Mylyns commons.ui is a single bundle and we only need it [29-7-2011 16:41:22] Isuru Udana: yes we can [29-7-2011 16:41:40] Wim Jongman: okay. Then let's use that [29-7-2011 16:41:46] Wim Jongman: It looks good [29-7-2011 16:42:00] Wim Jongman: Let's add it to a jar for now [29-7-2011 16:42:06] Wim Jongman: that's a good idea [29-7-2011 16:42:10] Isuru Udana: ok. [29-7-2011 16:42:12] Isuru Udana: thanks [29-7-2011 16:42:28] Isuru Udana: What do you think about the improvements ? [29-7-2011 16:42:42] Isuru Udana: Are they useful ? [29-7-2011 16:43:03] Wim Jongman: I have seen the following: [29-7-2011 16:43:50] Wim Jongman: if i subscribe to a new newsgroups then I get a popup for all the messages in the newsgroup. [29-7-2011 16:44:33] Wim Jongman: Also if I scroll down in the editor an new articles are fetched then I get notified. [29-7-2011 16:44:45] Wim Jongman: How can this be avoided? [29-7-2011 16:44:49] Isuru Udana: ahhh [29-7-2011 16:45:10] Isuru Udana: i will think and do something [29-7-2011 16:45:57] Wim Jongman: okay. I am not sure that it can be avoided. and it is not too bad because i get some kind of summary. Try it by subscribing to a new newsgroup. [29-7-2011 16:46:05] Wim Jongman: i wonder however if this takes much time [29-7-2011 16:46:34] Wim Jongman: Als, the article digest will crash if there is no active store [29-7-2011 16:46:55] Isuru Udana: ok. i will fix it [29-7-2011 16:47:24] Wim Jongman: And there is also a problem with the derby store if I have two eclipse programs open. Only one salvo can get to the database. [29-7-2011 16:47:40] Wim Jongman: Derby does not allow multiple connections [29-7-2011 16:47:50] Isuru Udana: ohhh [29-7-2011 16:48:11] Wim Jongman: We can't fix that real quick [29-7-2011 16:48:29] Isuru Udana: yes. [29-7-2011 16:48:37] Wim Jongman: no [29-7-2011 16:48:53] Isuru Udana: i mean we can't fix derby issue [29-7-2011 16:48:54] Wim Jongman: yes we cannot fix it quickly ;) [29-7-2011 16:49:03] Isuru Udana: :) [29-7-2011 16:49:21] Wim Jongman: okay. I am looking at the editor to make that more stable. [29-7-2011 16:49:33] Wim Jongman: I will have some commits soon [29-7-2011 16:49:46] Isuru Udana: ok. [29-7-2011 16:50:00] Wim Jongman: We now have one outstanding topic is that correct? [29-7-2011 16:50:24] Isuru Udana: i didn't get that [29-7-2011 16:50:42] Wim Jongman: the extension point or service [29-7-2011 16:50:52] Isuru Udana: yes [29-7-2011 16:51:24] Wim Jongman: Okay but lets first do a stabilzation round [29-7-2011 16:51:33] Isuru Udana: ok [29-7-2011 16:51:36] Wim Jongman: Maybe write some junit tests [29-7-2011 16:52:21] Isuru Udana: last few days i couldn't work on the project due to assignments of University [29-7-2011 16:52:36] Wim Jongman: is that now over? [29-7-2011 16:52:50] Isuru Udana: just finished a one now [29-7-2011 16:53:33] Isuru Udana: After a long academic strike finally our semester work has started. [29-7-2011 16:54:04] Isuru Udana: anyway I will work on the project as much as I can [29-7-2011 16:54:29] Wim Jongman: okay, it is only one month. try to stick with it [29-7-2011 16:54:40] Isuru Udana: I will manage my time [29-7-2011 16:54:44] Isuru Udana: i will do [29-7-2011 16:55:32] Isuru Udana: I am very interested on Salvo project. So I will keep working on it as much I can [29-7-2011 16:55:56] Wim Jongman: Great. Talk to you soon! [29-7-2011 16:56:01] Isuru Udana: ok. [29-7-2011 16:56:05] Isuru Udana: thank you [29-7-2011 16:56:14] Isuru Udana: have a nice time [29-7-2011 16:56:20] Wim Jongman: your welcome. Enjoy your weekend [31-7-2011 9:07:28] Isuru Udana: hi [3-8-2011 12:16:36] Isuru Udana: hi [3-8-2011 12:16:59] Wim Jongman: Hi Isuru [3-8-2011 12:17:14] Isuru Udana: shall we have a brief chat? [3-8-2011 12:17:24] Wim Jongman: Sure. What's up? [3-8-2011 12:17:44] Isuru Udana: im not clear about the use of command core expressions [3-8-2011 12:17:51] Isuru Udana: can you give me some hints [3-8-2011 12:18:04] Wim Jongman: Did you ever work with handlers and commands? [3-8-2011 12:18:17] Isuru Udana: i have used both [3-8-2011 12:19:24] Wim Jongman: For the handler you had to specify the activewhen in the extension point, remember? [3-8-2011 12:19:34] Isuru Udana: yes [3-8-2011 12:20:16] Wim Jongman: hang on one second [3-8-2011 12:20:21] Isuru Udana: ok [3-8-2011 12:20:43] *** Wim Jongman sent IMG_03082011_122043.png *** [3-8-2011 12:21:12] Wim Jongman: is this known to you? [3-8-2011 12:21:12] Isuru Udana: got it [3-8-2011 12:21:40] Wim Jongman: are you familliar with this [3-8-2011 12:21:41] Isuru Udana: yes [3-8-2011 12:21:47] Wim Jongman: these are core expressions [3-8-2011 12:21:56] Isuru Udana: ahhh ok [3-8-2011 12:22:26] Isuru Udana: ohhhh. not big there [3-8-2011 12:22:40] Wim Jongman: not big? [3-8-2011 12:23:09] Isuru Udana: ealier i though its something very complex framework [3-8-2011 12:23:38] Wim Jongman: well, it can become very complex [3-8-2011 12:23:50] Isuru Udana: so how can we use this to map views/ editors with Newsgroups [3-8-2011 12:24:24] Isuru Udana: is that what i have to figure out ? [3-8-2011 12:25:14] Wim Jongman: Suppose someone is working in Java in the Java perspective and wants to ask a question. [3-8-2011 12:25:22] Isuru Udana: ok [3-8-2011 12:25:45] Wim Jongman: Then we need to know which newsgroup and server this question needs to go to right? [3-8-2011 12:25:53] Isuru Udana: yes [3-8-2011 12:28:56] Wim Jongman: Suppose jdt uses our extension point newsgroupExtension and in there it says: Server: news.eclipse.org Newsgroup: org.eclipse.java.newcomer OR Class: INewsGrpoupFactory activeWhen with activePerspective = javaperspective [3-8-2011 12:29:47] Isuru Udana: ok [3-8-2011 12:30:35] Wim Jongman: If the server is not already there in salvo we will create it in the database. [3-8-2011 12:30:54] Wim Jongman: If the newsgroup is not already there then we subscribe [3-8-2011 12:31:15] Wim Jongman: and then the new question dialog pops up and the question is asked in the newsgroup. [3-8-2011 12:31:31] Wim Jongman: The Digest will then show when a new answer has arrived [3-8-2011 12:33:53] Isuru Udana: what i am not clear is, we show the detected newsgroup in the wizard. Can that be shown using this commad core expressions. [3-8-2011 12:34:27] Isuru Udana: i thought command core expressions are used to control only the menu item visibility, etc [3-8-2011 12:34:54] Wim Jongman: That is why they are called "core" expressions. They can be used for anything. [3-8-2011 12:35:08] Wim Jongman: We will read the extension point entries [3-8-2011 12:35:29] Wim Jongman: and then we will throw each expression in the expression evaluator [3-8-2011 12:35:40] Wim Jongman: which will return true or false [3-8-2011 12:37:44] Wim Jongman: Take a look at the handler extension point in org.eclipse.ui [3-8-2011 12:38:14] Isuru Udana: ok. you mean we will only get the correct one out of all extension point implementers [3-8-2011 12:38:43] Wim Jongman: Yes. But there could be more then one ofcourse. [3-8-2011 12:38:50] Isuru Udana: great [3-8-2011 12:38:52] Wim Jongman: Handlers don't allow it but we probably do [3-8-2011 12:39:04] Isuru Udana: yes we have to [3-8-2011 12:39:34] Isuru Udana: multiple newsgroups can be added to same project for different topics [3-8-2011 12:40:33] Wim Jongman: Yes that is true. Maybe the factory also needs to supply a description so that the user can decide which newsgroup to choose. [3-8-2011 12:40:53] Isuru Udana: yes we have to use a description [3-8-2011 12:41:10] Isuru Udana: that description has to be shown to the user [3-8-2011 12:41:23] Isuru Udana: so that he can choice the correct one [3-8-2011 12:41:27] Wim Jongman: Do you get the concept of the factory? [3-8-2011 12:41:57] Isuru Udana: i think it's provide the all the information of the newsgroup [3-8-2011 12:42:18] Wim Jongman: yes, exactly. [3-8-2011 12:42:35] Isuru Udana: i don't think we are creating a server instance there. [3-8-2011 12:43:03] Isuru Udana: factory is just provide us the information to create and subscribe to server, newsgroup [3-8-2011 12:43:10] Isuru Udana: am i correct? [3-8-2011 12:43:36] Wim Jongman: Yes. And only if the user selectes that server and newsgroup and if it not exist we will automatically subscribe to it. [3-8-2011 12:43:55] Isuru Udana: yes. that is what i was thinking [3-8-2011 12:44:15] Isuru Udana: thank you very much [3-8-2011 12:44:27] Isuru Udana: i got cleared my doubts [3-8-2011 12:44:27] Wim Jongman: Sure. thank you. Happy coding. [3-8-2011 12:44:36] Isuru Udana: I will :) [3-8-2011 12:44:51] Wim Jongman: Please look at the handler extension point of org.eclipse.ui [3-8-2011 12:44:57] Isuru Udana: ok [3-8-2011 12:44:58] Wim Jongman: You can sort of copy this [3-8-2011 12:45:04] Isuru Udana: :) [3-8-2011 12:45:08] Wim Jongman: :) [3-8-2011 12:45:34] Isuru Udana: hope i am in the correct path to complete the project [3-8-2011 12:45:55] Isuru Udana: thanks. bye
[14:54:41] Isuru Udana: hi [14:55:11] Wim Jongman: hi isuru [14:55:45] Isuru Udana: i couldn't reproduce the bug you mentioned [14:55:52] Isuru Udana: does that happens always ? [14:56:23] Wim Jongman: It could be a connection problem [14:56:34] Wim Jongman: I will keep an eye on it [14:56:35] Isuru Udana: yes. i thought the same [14:56:39] Isuru Udana: ok [14:56:51] Isuru Udana: i have made some minor changes [14:57:22] Isuru Udana: and now wizard picks the suggested newsgroup automatically [14:57:50] Isuru Udana: can you see the code? if it is ok we call pull that to main repository [14:57:59] Wim Jongman: Okay. did you move that to the top. Above the already existing list? [14:58:14] Isuru Udana: ahh no [14:58:17] Wim Jongman: It should only appear if there is a suggestion [14:58:32] Isuru Udana: ok. that can be done [14:58:42] Wim Jongman: Okay, nicew [14:58:44] Wim Jongman: nice [14:59:02] Isuru Udana: i will do that and inform you [14:59:05] Isuru Udana: thank you [14:59:05] Wim Jongman: Thanks!
[11-8-2011 13:20:50] Isuru Udana: hi [11-8-2011 13:28:55] Wim Jongman: hi [11-8-2011 13:29:26] Isuru Udana: i made the changes in the wizard [11-8-2011 13:29:33] Wim Jongman: nice [11-8-2011 13:29:35] Isuru Udana: can you have a lokk [11-8-2011 13:29:43] Isuru Udana: *look [11-8-2011 13:29:50] Wim Jongman: yes, can you make pull request? [11-8-2011 13:30:03] Isuru Udana: did you check it ? [11-8-2011 13:30:08] Wim Jongman: No but I think it is fine [11-8-2011 13:30:24] Isuru Udana: ok. i will send a pull request now [11-8-2011 13:30:31] Wim Jongman: I have some confidence in you by now [11-8-2011 13:36:17] Isuru Udana: i sent a pull request
[17:21:04] Isuru Udana: hi [17:21:40] Wim Jongman: Hi Isuru [17:22:06] Isuru Udana: Today is the soft pencil down deadline for gsoc [17:22:15] Wim Jongman: Ah, okay. [17:22:26] Isuru Udana: I hope you are satisfied with my work [17:22:37] Wim Jongman: I am very proud of you [17:22:46] Isuru Udana: Thank you very much [17:22:56] Wim Jongman: I hope you were happy with my coaching [17:23:08] Isuru Udana: yes of course [17:24:41] Wim Jongman: When does the gsoc project end? [17:25:17] Isuru Udana: hard pencil down date is 22nd this month [17:25:50] Wim Jongman: Okay so there is some room for some decoration [17:26:00] Isuru Udana: yes [17:26:55] Isuru Udana: I think we have some bugs to fix [17:27:01] Wim Jongman: Yes. [17:27:10] Isuru Udana: I will go through them [17:27:41] Wim Jongman: How about a small addition to the digest view: Only show articles if they are not read. [17:28:21] Wim Jongman: And I think we also have to put the server in the tree at some point [17:28:28] Wim Jongman: in the digest view [17:28:47] Isuru Udana: you mean multiple servers for digest view ? [17:28:58] Wim Jongman: yes [17:29:20] Wim Jongman: Are we going to switch to the main repository in github instead of pulling your repository [17:29:22] Isuru Udana: that will need some refactoring [17:29:58] Wim Jongman: yes it does. We need to optimize that view anyway because I would also like to see the colours like n the main article panel [17:30:09] Wim Jongman: But it is a great start [17:30:11] Isuru Udana: yeah [17:30:18] Isuru Udana: thanks [17:30:41] Wim Jongman: So we will both be programming in the main repository then? [17:30:50] Isuru Udana: ok [17:31:04] Wim Jongman: i have already given you commit rights to it [17:31:14] Isuru Udana: thank you [17:31:25] Wim Jongman: You have earned it. [17:31:43] Isuru Udana: So, you are going to pass me in the final evaluation [17:32:04] Wim Jongman: I cannot tell you that [17:32:07] Wim Jongman: :) [17:32:11] Isuru Udana: :)
Salvo GSOC project completed successfully.
Closing
