Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346257 - path filtering in LogCommand doesn't work
Summary: path filtering in LogCommand doesn't work
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Piotr Janik CLA
QA Contact:
URL: http://egit.eclipse.org/r/#change,3455
Whiteboard:
Keywords:
Depends on:
Blocks: 344683
  Show dependency tree
 
Reported: 2011-05-18 10:11 EDT by Piotr Janik CLA
Modified: 2011-05-18 11:40 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Janik CLA 2011-05-18 10:11:44 EDT 
I'm trying to use LogCommand in Orion and its path filtering introduced recently (https://bugs.eclipse.org/bugs/show_bug.cgi?id=340049).
However, filtering seems to not work correctly. When I add file path, I still receive list containing all of commits. I've tried to check some JGit tests covering this functionality, but I can't see any.
Comment 1 Tomasz Zarna CLA 2011-05-18 10:17:43 EDT 
Why don't you write such a test and submit it to Gerrit. Even though it will fail it should be a value thing to start with.

It's another blocker of bug 344683, isn't it?
Comment 2 Piotr Janik CLA 2011-05-18 10:24:11 EDT 
I've already done it. ;) 
Proposed fix and unit test for path filtering: http://egit.eclipse.org/r/#change,3455

Yes, it blocks bug 344683.
Comment 3 Chris Aniszczyk CLA 2011-05-18 11:40:20 EDT 
Merged as 7449b9a297af193107560c42508c53d7adb00226.

Thanks guys!