Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346255 - Consume new 'org.objectweb.asm' bundle from Orbit
Summary: Consume new 'org.objectweb.asm' bundle from Orbit
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 RC3   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 346210
Blocks:
  Show dependency tree
 
Reported: 2011-05-18 10:09 EDT by Dani Megert CLA
Modified: 2011-05-25 09:18 EDT (History)
3 users (show)

See Also:
daniel_megert: review+
Olivier_Thomann: review+
markus.kell.r: review+

Attachments
patch (22.52 KB, patch)
2011-05-24 09:50 EDT, Kim Moir CLA 		no flags Details | Diff
patch (22.52 KB, patch)
2011-05-25 09:18 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-05-18 10:09:13 EDT 
There was a problem in the 'org.objectweb.asm' bundle from Orbit which will be available during RC3. See bug 346210.

Consume new 'org.objectweb.asm' bundle from Orbit.
Comment 1 Dani Megert CLA 2011-05-18 10:10:22 EDT 
Kim, please do this once the Orbit bundle is available.
Comment 2 Kim Moir CLA 2011-05-24 09:50:58 EDT 
Created attachment 196438 [details]
patch
Comment 3 Kim Moir CLA 2011-05-24 10:02:50 EDT 
Dani, Olivier, Markus, please approve this change.
Comment 4 Olivier Thomann CLA 2011-05-24 10:12:14 EDT 
+1. So this is consuming all new orbit bundles for RC3.
Comment 5 Markus Keller CLA 2011-05-24 10:49:41 EDT 
+1. The only plug-in version change is for org.objectweb.asm (and .source). The manifest now also contains Eclipse-SourceReferences, but that doesn't hurt.

When I tried to download the new jar, I was redirected to an internal mirror that did not yet contain the new jar:
http://fullmoon.torolab.ibm.com/tools/orbit/downloads/drops/S20110521195923/repository/plugins/org.objectweb.asm_3.3.1.v201105211655.jar

I hope this is not an issue for the build.
Comment 6 Dani Megert CLA 2011-05-24 10:52:38 EDT 
+1 for RC3.
Comment 7 Kim Moir CLA 2011-05-24 10:59:29 EDT 
Markus, the build pulls from fullmoon.ottawa so this shouldn't be an issue. I just checked and it has the new build.  For some reason you guys are redirected to fullmoon.torolab which does not reliably rsync (slow).

Released fix for I20110525-0800.
Comment 8 Kim Moir CLA 2011-05-24 10:59:43 EDT 
closing
Comment 9 David Williams CLA 2011-05-25 01:00:51 EDT 
I'm sure Kim knows this, but I can't but try and be helpful ... we did come out with another "S build for RC3" from Orbit. 

http://download.eclipse.org/tools/orbit/downloads/drops/S20110523182458/ 

But it would have differed in only one, fixed bundle: com.google.inject. 

I doubt you use that, and if not then it'd be same content as using 
the one from S20110521195923. 

Just wanted to communicate well, in case anyone else "follows what you do" ... since everyone else should use S20110523182458. But I know you need to wait for it to replicate to ottawa, and not sure how long that takes (it was promoted just today). 

So ... no need to reply ... take if if helpful, ignore it if not.
Comment 10 Kim Moir CLA 2011-05-25 09:18:43 EDT 
Created attachment 196547 [details]
patch

Thanks David for letting me know, I've updated the Orbit build we use.  We don't use google.inject, so this is just a directory name change.  Thanks for being so helpful, as always :-)