Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346215 - [tracepoints] Tracepoints commands cannot have a comma in their name
Summary: [tracepoints] Tracepoints commands cannot have a comma in their name
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-18 06:39 EDT by Marc Khouzam CLA
Modified: 2011-06-27 14:38 EDT (History)
2 users (show)

See Also:
marc.khouzam: review? (nobody)

Attachments
Use a different delimiter than a comma (3.49 KB, patch)
2011-06-01 14:36 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Git patch for fix (3.38 KB, patch)
2011-06-27 14:37 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2011-05-18 06:39:51 EDT 
When creating a tracepoint command in DSF-GDB, if I put a comma in the name, the command seems to be ignored.

For example, if I name the command "collect delay,msg" and ask it to collect "delay,msg", I didn't see this command being send to GDB (I had two other commands set as well, and those were sent.
Comment 1 Marc Khouzam CLA 2011-06-01 14:36:43 EDT 
Created attachment 197136 [details]
Use a different delimiter than a comma

We should not use a comma as a delimiter for the different actions that can be part of a tracepoint.  This patch adds a different delimiter that is not going to be used by a user.
Comment 2 Marc Khouzam CLA 2011-06-27 14:37:05 EDT 
Created attachment 198672 [details]
Git patch for fix

This is the git patch that I have committed to master and to 8_0.
Comment 3 Marc Khouzam CLA 2011-06-27 14:38:48 EDT 
Mikhail, can you review?