Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346166 - [assist][rewrite] adding an import for the base side in declared lifting should create a base import
Summary: [assist][rewrite] adding an import for the base side in declared lifting shou...
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0 RC2   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 17:37 EDT by Stephan Herrmann CLA
Modified: 2011-06-02 10:47 EDT (History)
0 users

See Also:

Attachments
fix (3.89 KB, patch)
2011-05-22 09:01 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-05-17 17:37:24 EDT 
in a team method  like

  void test(Base as Role r) {
  }

if Base is unresolved that corresponding quickfix inserts a regular import
where it should better add a base import.
Comment 1 Stephan Herrmann CLA 2011-05-22 09:01:13 EDT 
Created attachment 196293 [details]
fix

Actually, the problem only occurred if no playedBy had been defined
before invoking quickfix. Anyway, here's a patch that also checks team
methods with declared lifting for hints on what types are base classes.
Comment 2 Stephan Herrmann CLA 2011-05-22 09:02:11 EDT 
Committed as r1621.
Comment 3 Stephan Herrmann CLA 2011-06-02 10:47:46 EDT 
Verified using build 201105311237

(works for quickfix and completion alike)