Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346162 - replace json in favor of gson
Summary: replace json in favor of gson
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 0.8   Edit
Assignee: Steffen Pingel CLA
QA Contact: Shawn Minto CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 17:13 EDT by Severin Gehwolf CLA
Modified: 2011-05-30 19:18 EDT (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (1.94 KB, application/octet-stream)
2011-05-17 18:15 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Severin Gehwolf CLA 2011-05-17 17:13:16 EDT 
Note that the component has been picked arbitrary.

org.eclipse.mylyn.reviews.core requires com.google.gson. Mylyn commons depends on org.json. It would be nice if Mylyn could only use one of them consistently as a dependency for JSON related things. Since org.json isn't really available under a free license, our preference would be Google GSON.

Thanks!
Comment 1 Steffen Pingel CLA 2011-05-17 18:15:12 EDT 
Created attachment 195914 [details]
mylyn/context/zip
Comment 2 Steffen Pingel CLA 2011-05-17 18:16:42 EDT 
Thanks for pointing that out. We started using JSon before adding the dependency on GSon in Reviews and I never realized that one library was sufficient. The code looks much nicer with GSon so I'll try that. 

This needs a bit more testing though and there is a chance that we need to revert in case unexpected problems arise.
Comment 3 Steffen Pingel CLA 2011-05-30 19:17:46 EDT 
Reopening to fix assignment.
Comment 4 Steffen Pingel CLA 2011-05-30 19:18:11 EDT 
Closing.