Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346075 - NPE when we try to open the comparison editor
Summary: NPE when we try to open the comparison editor
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 08:29 EDT by Cedric Notot CLA
Modified: 2011-05-17 10:27 EDT (History)
1 user (show)

See Also:

Attachments
The icon to add in org.eclipse.emf.compare.ui/icons/full (455 bytes, image/png)
2011-05-17 08:37 EDT, Cedric Notot CLA 		no flags Details
The icon to add in org.eclipse.emf.compare.ui/icons/full (139 bytes, image/png)
2011-05-17 08:38 EDT, Cedric Notot CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Notot CLA 2011-05-17 08:29:28 EDT 
Build Identifier: 1.2RC1

When we open the emf compare editor to compare two models, a null pointer exception is thrown and the editor does not open itself.

Some icons are not in the build.

Reproducible: Always

Steps to Reproduce:
1. Select two ecore file
2. Select "Compare each other" in the contextual menu
Comment 1 Cedric Notot CLA 2011-05-17 08:37:16 EDT 
Created attachment 195846 [details]
The icon to add in org.eclipse.emf.compare.ui/icons/full

The icon has to be added in  org.eclipse.emf.compare.ui/icons/full
Comment 2 Cedric Notot CLA 2011-05-17 08:38:51 EDT 
Created attachment 195847 [details]
The icon to add in org.eclipse.emf.compare.ui/icons/full

The icon has to be added in org.eclipse.emf.compare.ui/icons/full
Comment 3 Laurent Goubet CLA 2011-05-17 08:47:18 EDT 
This is a blocker in our RC1 build, yet we cannot commit the icons as is. Can you provide us with their source or confirm that your made them yourself and they can be used under the EPL?
Comment 4 Cedric Notot CLA 2011-05-17 09:01:42 EDT 
+ The "filter.png" icon, copyright free, comes from http://findicons.com/icon/232353/filter?id=232419 site.

+ The "category.png" icon, copyright free, comes from http://findicons.com/icon/418142/category?id=418250 site.
Comment 5 Laurent Goubet CLA 2011-05-17 09:02:47 EDT 
Thanks, this has now been contributed to HEAD and an RC1a build is incoming.
Comment 6 Laurent Goubet CLA 2011-05-17 10:27:17 EDT 
These icons can't be used as is, and they've been removed from the repository due to the impossibility to find their original source and license.