Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346066 - Usage of reserved words for variable names could cause problem.
Summary: Usage of reserved words for variable names could cause problem.
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: 3.0.0.M04   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.0.0.M06   Edit
Assignee: Chris Frost CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 06:34 EDT by Radoslav Ivanov CLA
Modified: 2011-08-22 07:21 EDT (History)
2 users (show)

See Also:

Attachments
Patch proposal for jsp-s which use "import" as variable name. (4.23 KB, patch)
2011-05-17 06:39 EDT, Radoslav Ivanov CLA 		glyn.normington: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Radoslav Ivanov CLA 2011-05-17 06:34:35 EDT 
Build Identifier: 3.0.0.M04

Hello

Eventually EL 2.1 does not validate strictly the usage of words for variable names. 

Therefore, when I am trying to use EL 2.2., I observed the following problem on requesting Virgo Admin Console:

org.apache.jasper.JasperException: /WEB-INF/jsp/state-bundle.jsp(99,6) "${import.provider eq null}" contains invalid expression(s): javax.el.ELException: The identifier [import] is not a valid Java identifier as required by section 1.19 of the EL specification (Identifier ::= Java language identifier). This check can be disabled by setting the system property org.apache.el.parser.SKIP_IDENTIFIER_CHECK to true.
        org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:41)


I prepared a patch which I am attaching to this report.

Best regards
Radoslav Ivanov

Reproducible: Always
Comment 1 Radoslav Ivanov CLA 2011-05-17 06:39:14 EDT 
Created attachment 195833 [details]
Patch proposal for jsp-s which use "import" as variable name.
Comment 2 Chris Frost CLA 2011-05-17 06:59:36 EDT 
Hi,

Thanks for patch, I'll have a look and probably apply it.

Chris.
Comment 3 Chris Frost CLA 2011-05-17 07:43:39 EDT 
Hi, I've checked it out and it all looks good.

Can you please state that you have permission to submit this patch to eclipse and that it is your own work. Thanks.

Once you have I can commit the patch.

Chris.
Comment 4 Radoslav Ivanov CLA 2011-05-17 08:07:50 EDT 
I state that I have permission to submit this patch to eclipse
and it is my own work.
Comment 5 Chris Frost CLA 2011-05-17 08:39:19 EDT 
Excellent, thank you. Need to keep the legal people happy. I've applied and pushed the patch, it will be in the next milestone.

Thank you for sending the patch in in the first place, appreciated.
Comment 6 Chris Frost CLA 2011-05-17 08:40:06 EDT 
Oh, forgot to mention. You are referenced as the author in the Git history :)