Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 346006 - Questionable paths being generated by PDE Build since 3.7M7
Summary: Questionable paths being generated by PDE Build since 3.7M7
Status: RESOLVED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-16 17:22 EDT by Chris Aniszczyk CLA
Modified: 2018-12-03 09:08 EST (History)
1 user (show)

See Also:


Attachments
post 3.7M7 build.xml (39.80 KB, text/xml)
2011-05-16 17:23 EDT, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2011-05-16 17:22:54 EDT
I believe this is related to bug 157375 being closed. I'm noticing that in the pdebuild scripts, these types of paths are being generated...


plugins/org.eclipse.pde.build/build.xml:		<mkdir dir="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208"/>
plugins/org.eclipse.pde.build/build.xml:		<unzip src="../../../../../../../../../../usr/lib/eclipse/plugins/com.ibm.icu_4.4.2.v20110208.jar" dest="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208" overwrite="false">
plugins/org.eclipse.pde.build/build.xml:			<pathelement path="${buildDirectory}/nestedJars/com.ibm.icu_4.4.2.v20110208/icu-data.jar"/>
plugins/org.eclipse.pde.build/build.xml:			<pathelement path="../../../../../../../../../../usr/lib/eclipse/plugins/com.ibm.icu_4.4.2.v20110208.jar"/>

Where in the past, we'd get something like "../com.ibm.icu_4.4.2.v20110208.jar"

Any thoughts of why this behavior changed?
Comment 1 Chris Aniszczyk CLA 2011-05-16 17:23:59 EDT
Created attachment 195795 [details]
post 3.7M7 build.xml
Comment 2 Andrew Niefer CLA 2011-05-17 16:08:42 EDT
Chris, I think this is just because the binary jars in the target are somewhere on disk far away from the buildDirectory.  I think that you might have seen this before the nested jar change.  We've always tried to do relative paths to help support something like the releng source build where Kim zips up the generated scripts for someone else to run.

Going from
/home/zx/eclipse/eb/org.eclipse.linuxtools.eclipse-build/eclipse-build/build/eclipse-3.7.0-I20110512-2000-src
to 
/user/lib/eclipse 

is pretty far for a relative path and in this case an absolute path would probably be better.  We could perhaps check if the relativization went all the way to the root and then just use absolute path if it did.
Comment 3 Lars Vogel CLA 2018-12-03 09:08:44 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.