Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345994 - Consume ECF 3.5.1
Summary: Consume ECF 3.5.1
Status: CLOSED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7 RC2   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 345186
Blocks:
  Show dependency tree
 
Reported: 2011-05-16 15:19 EDT by Pascal Rapicault CLA
Modified: 2011-05-18 16:31 EDT (History)
4 users (show)

See Also:
tjwatson: review+
john.arthorne: review+

Attachments
map file patch (6.67 KB, patch)
2011-05-18 11:12 EDT, Pascal Rapicault CLA 		no flags Details | Diff
patch for doc and platform feature (2.74 KB, patch)
2011-05-18 11:59 EDT, Kim Moir CLA 		no flags Details | Diff
patch to fix typo (903 bytes, patch)
2011-05-18 16:13 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2011-05-16 15:19:23 EDT 
We need to consume ECF 3.5.1 (see bug #345186).
Comment 1 Pascal Rapicault CLA 2011-05-17 13:42:42 EDT 
Kim, just a heads up that we will need your help on that.
Comment 2 Scott Lewis CLA 2011-05-17 23:56:06 EDT 
ECF 3.5.1 is now available here:

http://download.eclipse.org/rt/ecf/3.5.1/site.p2

p2 repo (duh)
Comment 3 Pascal Rapicault CLA 2011-05-18 11:12:57 EDT 
Created attachment 195988 [details]
map file patch

Here is a patch to the map file.
Comment 4 Kim Moir CLA 2011-05-18 11:59:29 EDT 
Created attachment 195997 [details]
patch for doc and platform feature
Comment 5 Kim Moir CLA 2011-05-18 12:05:32 EDT 
Started a test build here

https://hudson.eclipse.org/hudson/view/Eclipse%20and%20Equinox/job/eclipse-equinox-test-N/356/

Just as a fyi, I'm testing RC1 bundles in the builder too, thus if the build fails, it may be caused by these changes, not ECF.
Comment 6 Kim Moir CLA 2011-05-18 14:17:20 EDT 
The test build looks good.  

Tom, John please review.
Comment 7 Thomas Watson CLA 2011-05-18 15:11:14 EDT 
(In reply to comment #4)
> Created attachment 195997 [details]
> patch for doc and platform feature

In platformOptions.txt it seems that the line for org.eclipse.ecf should change:

;../org.eclipse.ecf_3.1.200.v20110313-1843.jar

to:

;../org.eclipse.ecf_3.1.300.v20110518-0313.jar

To align with the version of org.eclipse.ecf from the map file patch.
Comment 8 Kim Moir CLA 2011-05-18 16:13:40 EDT 
Created attachment 196046 [details]
patch to fix typo
Comment 9 Pascal Rapicault CLA 2011-05-18 16:31:07 EDT 
This has been released.