Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345919 - [client][git] Change Git clone UI for new API
Summary: [client][git] Change Git clone UI for new API
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 339145 340553 345935 346070 346492
Blocks:
  Show dependency tree
 
Reported: 2011-05-16 07:24 EDT by Malgorzata Janczarska CLA
Modified: 2011-09-01 11:41 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2011-05-16 07:24:58 EDT 
After fixing Bug 339854 git clone UI needs some changes.
Comment 1 Malgorzata Janczarska CLA 2011-05-16 14:10:07 EDT 
Things left to do:
1. when bug 345935 is fixed enable the delete action that would use Location as folder to remove
2. Link action should rather be removed
3. Add links to navigator based on Location (again bug 345935)
4. When bug 339145 is fixed change the cloning dialog to the directory picker
5. Update git wiki documentation:
http://wiki.eclipse.org/Orion/How_Tos/Working_with_git
http://wiki.eclipse.org/Orion/How_Tos/Cloning_repository_from_github
Comment 2 Tomasz Zarna CLA 2011-05-17 04:33:04 EDT 
(In reply to comment #1)
> Things left to do:
> 1. when bug 345935 is fixed enable the delete action that would use Location as
> folder to remove

While in the Repo UI I would use API from bug 340553 to delete a clone. Removing a clone may require some additional actions like closing resources, so it would be better to do it with a dedicated API.
Comment 3 Malgorzata Janczarska CLA 2011-05-17 08:56:04 EDT 
> 3. Add links to navigator based on Location (again bug 345935)
Done with commit b9eb8a6147904552c0300a2044aec5574e92cdec
Comment 4 Malgorzata Janczarska CLA 2011-05-27 09:40:57 EDT 
(In reply to comment #1)
> 1. when bug 345935 is fixed enable the delete action that would use Location as
> folder to remove
Done using git API
> 2. Link action should rather be removed
Done by Szymon
> 3. Add links to navigator based on Location (again bug 345935)
We won't be doing it probably
> 4. When bug 339145 is fixed change the cloning dialog to the directory picker
Done

Only left to do:
> 5. Update git wiki documentation:
> http://wiki.eclipse.org/Orion/How_Tos/Working_with_git
> http://wiki.eclipse.org/Orion/How_Tos/Cloning_repository_from_github
Comment 5 Malgorzata Janczarska CLA 2011-06-01 11:24:31 EDT 
> Only left to do:
> > 5. Update git wiki documentation:
> > http://wiki.eclipse.org/Orion/How_Tos/Working_with_git
> > http://wiki.eclipse.org/Orion/How_Tos/Cloning_repository_from_github

Done

Marking fixed.