Community
Participate
Working Groups
This bundle says Bundle-RequiredExecutionEnvironment: J2SE-1.5 in its manifest.mf file, which I am pretty sure is correct, since the code uses a number of "string".contains method throughout. But, says 1.4 in the .classpath file ... <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/J2SE-1.4"/> I noticed this because I loaded up freshly, and got a LOT of compile errors, because the workspace is using .classpath value. And, there is a warning in manifest.mf file that says "doesn't mactch". I suggest the .classpath be udpated to match the manifest.mf. Was this an oversite? Was something trying to be accomplished?
This is an oversight, and since part of my developent happens on a Mac under Show Leopard which has no JDK1.4, this wasn't spotted by me anyway. Should I fix+release this or does it require PMC+2 approval? (Actually, I have prepared a patch allowing all of the tests to run under JDK 1.4, but didn't finish it in time for 3.3, so that's for later)
It'd requires 1 PMC vote/review this week, and when it comes to unit test bundles, we're a little more relaxed. When you say "Should I fix+release this " ... if you mean fixing the .classpath file to match the BREE, then I would say yes. I would say to go ahead fix, and release, it but still "mark for PMC Review" just so there is better awareness of what's changing. (I would approve it quick, though). I think this important to fix since if someone "loads up the source" for our release (code or tests), it should compile cleanly! Guess it would if people didn't have a 1.4 jdk defined in their workbench, is what you are saying ... but, preferable to fix for those few like me :) that do.
Fixed and released as per previous comments. Marked for PMC review.
