Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345801 - Syntax error doesn't appear in Problems view
Summary: Syntax error doesn't appear in Problems view
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-14 03:09 EDT by Toshihiro Izumi CLA
Modified: 2015-10-22 10:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Toshihiro Izumi CLA 2011-05-14 03:09:10 EDT 
Make errorneous php file and save it
=> Problem marker appears on PHP Editor as usual but not in Problems view

Env:
Eclipse SDK 3.7M7
WTP 3.3.0M7
DLTK 3.0M7
PDT cvs-head

Cause:
org.eclipse.dltk.compiler.problem.DefaultProblemFactory

>    public String getMarkerType(IProblem problem) {
>        if (problem.getID() instanceof IProblemIdentifierExtension) {
>            return ((IProblemIdentifierExtension) problem.getID())
>                    .getMarkerType();
>        }
>        return problem.isTask() ? getTaskMarkerType() : getProblemMarkerType();
>    }
>
>    protected String getProblemMarkerType() {
        return DefaultProblem.MARKER_TYPE_TASK; // <<< should be MARKER_TYPE_PROBLEM
>    }
>
>    protected String getTaskMarkerType() {
>        return DefaultProblem.MARKER_TYPE_TASK;
>    }