Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345777 - Move 'Untrack' to Advanced Menu
Summary: Move 'Untrack' to Advanced Menu
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 15:20 EDT by Chris Aniszczyk CLA
Modified: 2013-05-01 09:09 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2011-05-13 15:20:44 EDT 
These actions aren't used as much.
Comment 1 Chris Aniszczyk CLA 2011-05-13 15:20:56 EDT 
Thoughts guys?
Comment 2 Kevin Sawicki CLA 2011-05-14 23:26:23 EDT 
I definitely think Untrack should be under Advanced.  I'm less sure about Add because it is unclear to me how/why people use it currently
since the commit dialog supports committing untracked and staged files so I personally never find myself using it.
Comment 3 Jens Baumgart CLA 2011-05-17 03:29:28 EDT 
I think the Add action should stay in the main menu. It's needed for resolving conflicts and with future improvements (staging view) it will become more important.
Comment 4 Chris Aniszczyk CLA 2011-05-17 12:25:51 EDT 
Ok, I'll move Untrack to the Advanced menu then.
Comment 5 Tomasz Zarna CLA 2013-03-19 14:28:41 EDT 
(In reply to comment #4)
> Ok, I'll move Untrack to the Advanced menu then.

It looks it did not happen, maybe I will have more luck with https://git.eclipse.org/r/#/c/11317/
Comment 6 Matthias Sohn CLA 2013-03-20 21:10:37 EDT 
merged as e43049cc499dfc716b7d103053d4a3126e77c847
Comment 7 Matthias Sohn CLA 2013-03-20 21:14:26 EDT 
I had to rebase so this became 9ca5ae11e97744a2023a61ffd495fd6da94b0b93
Comment 8 Dani Megert CLA 2013-04-26 06:44:26 EDT 
There are three issues with that:

1) The enable expression is wrong and will be ignored. As a result, one can invoke the Untrack operation on non-Git resources. Did not check whether this can lead to some bad issues.

2) When using latest EGit with Eclipse 3.x, one gets a log entry on each start:
!ENTRY org.eclipse.ui 2 0 2013-04-26 12:06:34.737
!MESSAGE Warnings while parsing the handlers from the 'org.eclipse.ui.handlers' extension point.
!SUBENTRY 1 org.eclipse.ui 2 0 2013-04-26 12:06:34.737
!MESSAGE Handlers need a class: plug-in='org.eclipse.egit.ui', id='org.eclipse.egit.ui.team.Untrack'

3) It leaves dead code in the project (UntrackAction).

The second problem is not a bug in the EGit's plugin.xml, but a bug in 3.x when checking the handler contribution: it expects a class and does not check for a default handler. Given that there are no further builds and that EGit wants to be compatible with older version, we should workaround that in EGit.


Pushed polish fix to Gerrit: https://git.eclipse.org/r/12231
Comment 10 Dani Megert CLA 2013-05-01 09:09:36 EDT 
Verified in 3.0.0.201305010921.