Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345771 - Release... command tags entire build notes project even if "Release only changed projects" unchecked
Summary: Release... command tags entire build notes project even if "Release only chan...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7 RC3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 14:54 EDT by Markus Keller CLA
Modified: 2011-05-25 03:40 EDT (History)
1 user (show)

See Also:
markus.kell.r: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-05-13 14:54:45 EDT 
I20110512-2000

The Team > Release... command screws buildnotes when "Release only changed projects" is not checked.

The last time I released something from that workspace, I had to update the Platform UI build notes, so I had the checkbox checked, and on "Notes for build Changes" page, I had /org.eclipse.ui/buildnotes_workbench.html selected.

But now, I wanted to release just org.eclipse.jdt.text.tests, so I invoked Release on that project. Then I unchecked "Release only changed projects" and continued. When I saw that the tool went off and tagged the org.eclipse.ui project, I cancelled (which worked, but now the buildnotes file has been tagged with an tags).
Comment 1 Dani Megert CLA 2011-05-23 09:27:10 EDT 
Let me fix this.
Comment 2 Dani Megert CLA 2011-05-23 09:40:47 EDT 
Fixed in org.eclipse.releng.tools.ReleaseWizard.java, rev. 1.21.

Markus, can you verify? I'll then release it to the build.
Comment 3 Markus Keller CLA 2011-05-23 10:29:04 EDT 
Looks good (except for the double indent). Verified with a toy setup that it works.
Comment 4 Dani Megert CLA 2011-05-23 11:25:34 EDT 
> Looks good (except for the double indent). Verified with a toy setup that it
> works.
Fixed.

> Markus, can you verify? I'll then release it to the build.
Released.
Comment 5 Dani Megert CLA 2011-05-25 03:40:03 EDT 
Verified in I20110524-0900.