Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345769 - [Accessibility] The button in the top right hand corner of the Preferences Dialog does not have a tooltip/MSAA name
Summary: [Accessibility] The button in the top right hand corner of the Preferences Di...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.5.2   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 14:42 EDT by Chih-Hung Chiang CLA
Modified: 2011-06-24 10:35 EDT (History)
6 users (show)

See Also:


Attachments
snap shot of the button (1.16 MB, image/bmp)
2011-05-13 14:45 EDT, Chih-Hung Chiang CLA
no flags Details
Patch (1.54 KB, patch)
2011-06-24 10:34 EDT, Oleg Besedin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chih-Hung Chiang CLA 2011-05-13 14:42:43 EDT
Build Identifier: M20100211-1343

When focus is given to the button in the top right hand corner of the Preference Dialog page, there is no indication as to what the control could possibly do. JAWS will only announce a toolbar button.

Reproducible: Always

Steps to Reproduce:
1.Open preference through window -> preferences
2.Tab to the button in the top right hand corner of the preference page
3.JAWS will only announce a toolbar button, no tooltip too.
Comment 1 Chih-Hung Chiang CLA 2011-05-13 14:45:27 EDT
Created attachment 195626 [details]
snap shot of the button
Comment 2 Dani Megert CLA 2011-05-16 04:34:16 EDT

*** This bug has been marked as a duplicate of bug 325899 ***
Comment 3 Chih-Hung Chiang CLA 2011-05-18 17:02:06 EDT
The fix in Bug 325899 (add tooltip "Menu") may not be sufficient.

1. To have JAWS identify it as a "Menu toolbar button" provides no more information to the blind user. How about use "More navigation actions" for the tooltip?

2. Can we add MSAA name to this button?
Comment 4 Carolyn MacLeod CLA 2011-05-19 09:21:34 EDT
Re: comment 3

The problem is that it's in a framework that is used for properties dialogs as well as the preferences dialogs. So whatever name is used needs to be appropriate for all of those uses... unless someone wants to change the framework to allow passing that string in.   ;)

The framework takes the tooltip string and uses that for the MSAA name string. So this button already does have an MSAA name.
Comment 5 mukundan desikan CLA 2011-05-20 10:32:23 EDT
Just curious to know what happens when the user clicks "Key Scrolling" from that button? Seems nothing gets highlighted in the UI.
Comment 6 Carolyn MacLeod CLA 2011-05-20 10:44:52 EDT
> what happens when the user clicks "Key Scrolling"

- Go to a large-ish preference page, for example, General - Appearance.
- Resize the Preferences dialog to be smaller (i.e. as if you were working on a small-screen laptop, or maybe using a very large font). You should see scrollbars.
- Now try the Key Scrolling menu item again - left and right arrows scroll the "Appearance" page left and right, up and down arrows scroll up and down.
Comment 7 Chih-Hung Chiang CLA 2011-05-20 11:07:53 EDT
Hi Carolyn,

Thanks for the response.

The reason I was asking about the MSAA name is because I thought we can have both the tooltip and MSAA name defined separately, and JAWS will announce MSAA name if we don't want to change the tooltip string.

Anyway, according to our Accessibility expert, let JAWS announce "tool bar menu button" is not sufficient for blind user. the proposed string change should be appropriate for both preference and property dialog, but that's just a suggestion. Maybe someone understand this menu better will have better description for it.
Comment 8 Carolyn MacLeod CLA 2011-05-20 13:01:53 EDT
At the lowest level (my level... the SWT level) the tooltip and MSAA name are defined separately. However, the Eclipse UI framework (built on top of SWT) doesn't have a way to define either of those strings for this particular button. The framework was designed a long time ago, and it is unlikely that it will be changed to allow setting of either of these strings for this particular menu name. (At least, not for Eclipse 3.7, which is almost shipping).

So let's see if there is a better string that fits all cases and is useful for everybody.

This menu was originally added because people could not resize the tree or scroll the scrollbars using only the keyboard. So the menu itself is mostly there to improve accessibility.

We added the "Menu" tooltip and MSAA name because JAWS originally just said "tool bar button". Now it says "tool bar menu button" which is a lot better.

If we want to change this string (i.e. maybe change it to Navigation Menu, so that JAWS says "tool bar navigation menu button") then we need to know if this menu is ever going to be used for anything else. I'm not sure if we know that.

For example, the very similar "View Menu" that can be found in a view is called "View Menu" because it can contain just about anything that the view provider wants. So that string needs to remain generic.

I am going to stop talking now and let the UI folks on this bug decide whether or not the string "Navigation Menu" (or something similar) is appropriate for this tool item.
Comment 9 mukundan desikan CLA 2011-05-25 13:18:40 EDT
Hi Carolyn -  If there any update on this issue can u please let us know. Since its a accessibility issue , we are tracking it as high priority issue and like to get it resolved sooner.
Comment 10 Carolyn MacLeod CLA 2011-05-25 16:31:39 EDT
It's out of my hands - I do not choose the strings, and I do not own the framework.  Reassigning to Oleg, who will be able to give you an update.
Comment 11 Oleg Besedin CLA 2011-05-27 10:18:57 EDT
We are in RC4 now, see http://www.eclipse.org/eclipse/development/plans/freeze_plan_3_7.php  . Only critical changes should go into 3.7 at this point.
Comment 12 Paul Webster CLA 2011-06-02 09:57:24 EDT
This needs to be consistent with the dropdown menu that we have in views.  That
says View Menu.  That implies this should read Dialog Menu, as in general it is
to serve the same function as the view menu for a given dialog.

That it contains navigation actions is a side effect of what we put there to
date.

PW
Comment 13 Oleg Besedin CLA 2011-06-24 10:34:18 EDT
Created attachment 198539 [details]
Patch

Changing tooltip text to "Additional Dialog Actions".
Comment 14 Oleg Besedin CLA 2011-06-24 10:35:07 EDT
Patch applied to CVS Head.