Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345764 - DND moves tab to the end even though it seems like a no-op
Summary: DND moves tab to the end even though it seems like a no-op
Status: RESOLVED WORKSFORME
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-13 14:03 EDT by Remy Suen CLA
Modified: 2013-06-06 11:54 EDT (History)
1 user (show)

See Also:

Attachments
Adjust the 'dropIndex' to reflect the index in the model rather than the CTabItem index (1.47 KB, patch)
2011-05-27 13:22 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-05-13 14:03:31 EDT 
1. Begin dragging the first tab of a stack.
2. Drag it so that the green line shows up to the left of its tab.
3. Release the mouse.
4. The tab magically gets moved to the end of the list.
Comment 1 Eric Moffatt CLA 2011-05-24 14:58:13 EDT 
Just checked in I20110523-2200 and dropping into a stack between tabs seems to be almost completely broken...next on the hit list...
Comment 2 Eric Moffatt CLA 2011-05-27 13:22:47 EDT 
Created attachment 196789 [details]
Adjust the 'dropIndex' to reflect the index in the model rather than the CTabItem index


We weren't taking closed view's placeholders into account...
Comment 3 Eric Moffatt CLA 2011-05-27 13:23:54 EDT 
Committed in >20110527. Applied the patch.
Comment 4 Dani Megert CLA 2013-06-05 10:57:18 EDT 
Removing outdated target milestone.
Comment 5 Eric Moffatt CLA 2013-06-06 11:54:31 EDT 
This has already been addressed through other DnD fixes...