Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345654 - TLS Renegotiation should not be enabled by default
Summary: TLS Renegotiation should not be enabled by default
Status: RESOLVED WONTFIX
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 7.2.x   Edit
Assignee: Greg Wilkins CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 16:02 EDT by Chad La Joie CLA
Modified: 2011-09-06 07:14 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chad La Joie CLA 2011-05-12 16:02:49 EDT 
Build Identifier: 7.3.1

In SslContextFactory, TLS renegotiation is enabled by default.  A few years ago a vulnerability was discovered[1] in HTTPS that uses this feature.  A TLS extension[2] was added to address this, however I don't see any code checking to see if the client supports secure renegotiation.  If there isn't any such code (I very well may simply have missed it), then renegotiation support should be disabled by default.

[1] http://www.educatedguesswork.org/2009/11/understanding_the_tls_renegoti.html
[2] http://tools.ietf.org/html/rfc5746

Reproducible: Always
Comment 1 Greg Wilkins CLA 2011-05-12 23:42:21 EDT 
Chad,

the renegotiation enabling was added to jetty in response to that vulnerability and we initially set to disabled.

However, after several releases of JVM's and browsers that support rfc5746, we switched the default to enabled.

I can't see anything in the java SSLEngine API that would allow us to detect if RFC5746 is being supported?  Do you know of such a check?   If so, then we would use that anded with the boolean.
Comment 2 Greg Wilkins CLA 2011-09-06 00:48:13 EDT 
Chad,

I think the vulnerability has been fixed long enough now that we don't need to default to no renegotiation
Comment 3 Chad La Joie CLA 2011-09-06 07:14:27 EDT 
Personally I still think it should be disabled as the majority of browsers still in use today don't have the TLS patch.  But I understand that's just a matter of personal preference.