Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345646 - [select] F3 not working for a specific signature-less callin binding
Summary: [select] F3 not working for a specific signature-less callin binding
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.1 M3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 15:12 EDT by Stephan Herrmann CLA
Modified: 2013-01-15 16:51 EST (History)
0 users

See Also:

Attachments
test & fix (4.16 KB, patch)
2011-11-08 06:31 EST, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-05-12 15:12:54 EDT 
Placing the curser on the role method in 

 org.eclipse.objectteams.otdt.internal.corext.CallHierarchyAdaptor.MethodMappingWrapper.doFindChildren <- doFindChildren

and hitting F3 doesn't work, the status line reports:

Current text selection cannot be opened in an editor.

For all other callin bindings in the same team class it works OK.
Not sure what's special here.
Comment 1 Stephan Herrmann CLA 2011-05-12 15:21:47 EDT 
Another (possibly unrelated) failure of F3:
Inside org.eclipse.objectteams.otdt.internal.debug.adaptor.PresentationAdaptorActivator.EditorBasedAdaptation.adaptedRun(ITextEditor)

click on adaptor.setTextEditor(..) and again F3 doesn't work.

Also note, that in both cases "copy qualified name" does not work for a role element
(method or callin as pasted into this bug) whereas it works from the bread crumbs.
Comment 2 Stephan Herrmann CLA 2011-08-27 10:26:17 EDT 
put on radar.
Comment 3 Stephan Herrmann CLA 2011-08-27 10:27:18 EDT 
.
Comment 4 Stephan Herrmann CLA 2011-11-08 06:31:18 EST 
Created attachment 206579 [details]
test & fix

Fixed by removing some bogus code from SelectionOnMethodSpec,
which had been in there for 7 years for no clear purpose.

The issue popped up because findExactMethod stumbled on a parameter type
for which the hierarchy was not yet connected, so we should be careful
with only using findExactMethod without findMethod. But as said, all this
wasn't even necessary.
Comment 5 Stephan Herrmann CLA 2011-11-08 06:40:44 EST 
Released for 2.1 M3 (r2094/5).
Comment 6 Stephan Herrmann CLA 2011-12-16 15:35:01 EST 
Verified using build 201112131519.
Comment 7 Stephan Herrmann CLA 2012-01-17 13:19:45 EST 
The fix has been backported to 2.0.2 via commit f3b2f1f8f0d88129c8aa72e8730a4785d51f4b84