Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345631 - Reuse Compare Editor doesn't work
Summary: Reuse Compare Editor doesn't work
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 347555 347929 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-05-12 13:35 EDT by Ian Bull CLA
Modified: 2011-09-16 08:36 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2011-05-12 13:35:32 EDT 
I'm not sure what 'reuse compare editor' (in Git Tree Compare view) does, but I'm pretty sure it doesn't work.

With the latest egit nightly: 1.0.0.201105100915

If I select a project and say "Compare with HEAD", the Git Tree Compare view opens. If I double click on a file to see the differences, the compare editor quickly opens and then closes.  There is nothing in the log.

If I deselect 'reuse compare editor' then it works as expected.
Comment 1 James Blackburn CLA 2011-05-28 15:00:46 EDT 
*** Bug 347555 has been marked as a duplicate of this bug. ***
Comment 2 James Blackburn CLA 2011-05-28 15:03:02 EDT 
Eclipse EGit (Incubation)    1.0.0.201105261513 org.eclipse.egit.feature.group Eclipse EGit
Eclipse JGit (Incubation)    1.0.0.201105251218 org.eclipse.jgit.feature.group Eclipse JGit

I'm seeing this too, with a couple extensions:
 - When I deselect 'reuse compare editor', I get two compare editors every time I double click in the tree compare view.
 - 'reuse compare editor' seems to be the default, which appears to make this view non-working out-the-box.
Comment 3 Matthias Sohn CLA 2011-06-29 04:58:06 EDT 
*** Bug 347929 has been marked as a duplicate of this bug. ***
Comment 4 Dani Megert CLA 2011-08-26 05:00:28 EDT 
Also doesn't work for me. Unless I disable that option, I can't open any editor.

This is with 1.1.0.201108251914.
Comment 5 Remy Suen CLA 2011-08-26 19:03:51 EDT 
A change set has been pushed to Gerrit for review.
http://egit.eclipse.org/r/#change,4074
Comment 7 Dani Megert CLA 2011-09-16 08:36:52 EDT 
Verified in 1.1.0.201109151100-r.