Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345628 - [1.7] Rename disjunctive type to union type
Summary: [1.7] Rename disjunctive type to union type
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 13:04 EDT by Olivier Thomann CLA
Modified: 2011-08-05 02:54 EDT (History)
4 users (show)

See Also:

Attachments
Patch (77.51 KB, patch)
2011-05-17 10:39 EDT, Satyam Kandula CLA 		no flags Details | Diff
renaming left overs (5.21 KB, patch)
2011-06-28 10:21 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2011-05-12 13:04:29 EDT 
The latest version of the specification renamed disjunctive type to be union type.

This should be reflected inside class, field, methods names.
Comment 1 Srikanth Sankaran CLA 2011-05-13 01:02:19 EDT 
Satyam, please follow up, TIA.
Comment 2 Satyam Kandula CLA 2011-05-17 10:39:50 EDT 
Created attachment 195866 [details]
Patch

Modified all references to disjunctive to union. Even modified the comments too. 

Haven't included the parser resource files in the patch as there are binary.
Comment 3 Satyam Kandula CLA 2011-05-18 00:38:43 EDT 
Released the patch
Comment 4 Satyam Kandula CLA 2011-05-18 00:43:39 EDT 
Deepak, I have made changes to all references to Disjunctive type to Union type. If you have used this type, please modify accordingly.
Comment 5 Deepak Azad CLA 2011-05-18 03:25:29 EDT 
Thanks Satyam. I have updated the references in o.e.jdt.ui.

3 files were modified.
GenericVisitor.java
ASTFlattener.java
HierarchicalASTVisitor.java
Comment 6 Stephan Herrmann CLA 2011-06-28 09:56:31 EDT 
I found a few left overs: CompletionParser and ThrownExceptionFinder
have some local variables like:
  UnionTypeReference disjunctiveTypeReference

Should we include the (trivial) fix in this bug, too?
Comment 7 Olivier Thomann CLA 2011-06-28 10:02:57 EDT 
(In reply to comment #6)
> I found a few left overs: CompletionParser and ThrownExceptionFinder
> have some local variables like:
>   UnionTypeReference disjunctiveTypeReference
> 
> Should we include the (trivial) fix in this bug, too?
yes please.
Comment 8 Stephan Herrmann CLA 2011-06-28 10:21:41 EDT 
Created attachment 198736 [details]
renaming left overs

This patch renames the local variables mentioned in comment 6
and adjusts two comments in tests.
Comment 9 Stephan Herrmann CLA 2011-06-28 10:29:29 EDT 
Verified by code inspection:
After applying the patch from comment 8 jdt.core and its test projects
contain no more mentions of "disjunctive" (except in buildnotes).