Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345614 - Restore Defaults in Code Analysis preferences
Summary: Restore Defaults in Code Analysis preferences
Status: VERIFIED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0.2   Edit
Assignee: Elena Laskavaia CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 11:18 EDT by Andrew Gvozdev CLA
Modified: 2014-01-29 22:53 EST (History)
4 users (show)

See Also:

Attachments
Patch to fix the reported problem (2.00 KB, patch)
2011-07-27 14:25 EDT, Otavio Pontes CLA 		cdtdoug: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Gvozdev CLA 2011-05-12 11:18:02 EDT 
Restore Defaults button in Codan preferences does not have any observable effect. I expected all the checkers to reset to the default state.
Comment 1 Otavio Pontes CLA 2011-07-27 14:25:59 EDT 
Created attachment 200463 [details]
Patch to fix the reported problem

The patch was tested in master and cdt_7_0_1 branches.
If there is something in the patch that should be improved or fixed just let me know.
Thanks
Comment 2 Otavio Pontes CLA 2011-09-21 11:18:32 EDT 
Anyone has tested or review my patch?
Any idea if here is anything to change or if this will be applied upstream?
Thanks
Comment 3 Elena Laskavaia CLA 2011-10-25 14:37:05 EDT 
I will look at it thanks
Comment 4 Elena Laskavaia CLA 2011-10-25 14:38:50 EDT 
Why do you set setPresentsDefaultValue(false) ?
Comment 5 CDT Genie CLA 2011-10-25 21:23:02 EDT 
*** cdt git genie on behalf of Otavio Pontes ***

    Bug 345614 - restore default button in codan preferences

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=2b1951b4cdeb9fbaca616fbc8145434655439016
Comment 6 Otavio Pontes CLA 2011-10-26 15:08:09 EDT 
It is suppose to be setPresentsDefaultValue(true); I don't know why I put false in that field.
Thanks for the commit. It is working fine here.
Comment 7 Otavio Pontes CLA 2012-01-02 07:27:32 EST 
Isn't that bug fixed? Can anyone set it as resolved?
Comment 8 Marc-André Laperle CLA 2012-01-05 01:52:44 EST 
Alena, I think this would be a good fix for 8.0.2. I can commit it to the cdt 8 branch as well if you don't mind?
Comment 9 Marc-André Laperle CLA 2012-01-07 23:02:55 EST 
Fixed in 8.0.2 also.
Comment 10 Marc-André Laperle CLA 2012-01-21 23:14:33 EST 
Verified in 8.0.2 RC1.
Comment 11 CDT Genie CLA 2012-02-29 13:20:49 EST 
*** cdt git genie on behalf of Otavio Pontes ***

    Bug 345614 - restore default button in codan preferences

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=9e260b1c8d7eddc0d6e01621fb5ebdad1ccbaad4