Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345597 - [Theming] Background color is not applied
Summary: [Theming] Background color is not applied
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.4 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 09:24 EDT by Oliver B. CLA
Modified: 2011-05-16 15:48 EDT (History)
1 user (show)

See Also:

Attachments
Example (2.15 KB, text/x-java)
2011-05-12 09:24 EDT, Oliver B. CLA 		no flags Details
Proposed patch (10.42 KB, patch)
2011-05-16 05:13 EDT, Ivan Furnadjiev CLA 		ivan: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver B. CLA 2011-05-12 09:24:11 EDT 
Created attachment 195495 [details]
Example

The background color of Text/Combo is not always applied. The standard css theme value will be used initialy. But when a color is set manually with setBackground the new color will not be applied. The same happens with css-states like read-only.

This was tested using the following themes:
own custom theme, rap-default and fancy

The old classic theme does not have this problem.

A small sample dialog is attached.
The background of CCombo, DateTime, Label is working. But not for Text/Combo.

Tested wird RAP 1.4M7 and HEAD (RWT-standalone).
Last tested working version was RAP 1.4M5.
Comment 1 Ivan Furnadjiev CLA 2011-05-13 04:10:24 EDT 
The reason for this issue is the new default background gradient set on Combo/Text by the default theme. As a temporary workaround, reset the Combo/Text CSS background-image property to none in your custom CSS.
Comment 2 Oliver B. CLA 2011-05-13 04:18:17 EDT 
The workaround with the css backround-image worked.
Comment 3 Ivan Furnadjiev CLA 2011-05-16 04:17:37 EDT 
Because of the default background gradient, the background mode does not work for Text/Combo as well. Reproducible with Controls Demo -> Composite tab, change "background mode" radio buttons.
Comment 4 Ivan Furnadjiev CLA 2011-05-16 05:13:22 EDT 
Created attachment 195700 [details]
Proposed patch

This patch remove/reset background gradient from the server-side if background color have to be set.
Comment 5 Ralf Sternberg CLA 2011-05-16 15:48:05 EDT 
The patch looks good to me. Applied to CVS HEAD.