Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345589 - [refactoring/serializer] Make refactoring work with both serializer versions
Summary: [refactoring/serializer] Make refactoring work with both serializer versions
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: SR2   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-12 08:36 EDT by Jan Koehnlein CLA
Modified: 2017-09-19 18:00 EDT (History)
2 users (show)

See Also:
jan: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koehnlein CLA 2011-05-12 08:36:34 EDT 
Rename refactoring is using an org.eclipse.xtext.parsetree.reconstr.ITokenSerializer.ICrossReferenceSerializer to decide on the new text for a cross reference. It has to be clarified how it should work with the new serializer architecture.
Comment 1 Sebastian Zarnekow CLA 2011-05-30 03:45:52 EDT 
Easy solution: 

Add an adapter inbetween with two implementations. Have a default binding that uses the old cross reference serializer. Add an explicit binding in the new serializer fragment.
Comment 2 Jan Koehnlein CLA 2011-09-01 09:51:50 EDT 
Introduced a CrossReferenceSerializerFacade. 

The CRS is selected with tregard to the binding of the ISerializer interface, because there are default bindings for both CRSs and a client can use the new serializer without the SerializerFragment.

The facade also contains a hook to resolve name collisions introduced by the refactoring.
Comment 3 Karsten Thoms CLA 2017-09-19 17:49:30 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 4 Karsten Thoms CLA 2017-09-19 18:00:33 EDT 
Closing all bugs that were set to RESOLVED before Neon.0