Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345554 - SWTBot regression on build 303
Summary: SWTBot regression on build 303
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 345694 (view as bug list)
Depends on:
Blocks: 345694
  Show dependency tree
 
Reported: 2011-05-12 04:55 EDT by Nicolas Guyomar CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: indigo+


Attachments
Patch for SWTBotRegressionBuild303 (5.92 KB, patch)
2011-05-12 04:55 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff
Patch for SWTBotRegressionBuild303_V2 (1.64 KB, patch)
2011-05-12 05:58 EDT, Nicolas Guyomar CLA
gdupe: iplog+
Details | Diff
Patch for Bug 345554 Join refresh job (6.40 KB, patch)
2011-05-13 04:01 EDT, Nicolas Guyomar CLA
nicolas.bros: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2011-05-12 04:55:56 EDT
Created attachment 195473 [details]
Patch for SWTBotRegressionBuild303

Hi,

Some tests are failing on Hudson, please find attached a patch on TableEditabilityTest.java which add some screenShots to understand what is happening

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 1 Gregoire Dupe CLA 2011-05-12 05:16:50 EDT
Comment on attachment 195473 [details]
Patch for SWTBotRegressionBuild303

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution and launch a build.

Committed revision 644.
Comment 2 Nicolas Guyomar CLA 2011-05-12 05:58:33 EDT
Created attachment 195482 [details]
Patch for SWTBotRegressionBuild303_V2

The tests are failing because org.eclipse.swt.widgets.List are not matched on Hudson, while they are matched on my computer.

Here is a patch with another screenShot to try to understand where is the difference

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 3 Gregoire Dupe CLA 2011-05-12 11:42:10 EDT
Comment on attachment 195482 [details]
Patch for SWTBotRegressionBuild303_V2

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution and launch a build.

Committed revision 645.
Comment 4 Nicolas Guyomar CLA 2011-05-13 03:58:03 EDT
*** Bug 345694 has been marked as a duplicate of this bug. ***
Comment 5 Nicolas Guyomar CLA 2011-05-13 04:01:34 EDT
Created attachment 195563 [details]
Patch for Bug 345554 Join refresh job

Hi,

Since we introduced a refresh job in the table, some SWTBot tests are failing.
I suspect that it is because SWTBot run quite fast, and that the refresh job
has not the time to complete between 2 edit actions.

This is why I need to add a way to wait for any refresh job to finish, so that
I would hopefully get rid of the failing tests.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Regards,
Nicolas Guyomar
Comment 6 Nicolas Bros CLA 2011-05-13 05:22:19 EDT
Comment on attachment 195563 [details]
Patch for Bug 345554 Join refresh job

This is a contribution from an employee of Mia-Software, targeting a future
Indigo release. The company has signed a Member Committer Agreement. The
contribution does not need a CQ (see bug 322327).
Comment 7 Gregoire Dupe CLA 2011-05-13 09:19:02 EDT
The build 313 and 314 doesn’t contain any test failure. We can then assume that this bug is fixed.

Regards,
Grégoire Dupé
Comment 8 Gregoire Dupe CLA 2011-05-16 09:31:26 EDT
Comment on attachment 195563 [details]
Patch for Bug 345554 Join refresh job

Hello,

This patch has been committed with too many code formatting. To apply older patch is then really painful (I’m trying to commit the patches of the Bug 344925). I’ll revert those changes and reapply the patch without the unexpected code formatting.

Regards,
Gregoire Dupe
Comment 9 Gregoire Dupe CLA 2011-05-16 10:13:23 EDT
Comment on attachment 195563 [details]
Patch for Bug 345554 Join refresh job

I've switch back to the revision 641 (Committed revision 654) and re applied the patch (Committed revision 655 and 656)

Regards,
Gregoire Dupe