Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345513 - "Show files with equal content" needs a new icon
Summary: "Show files with equal content" needs a new icon
Status: VERIFIED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 23:12 EDT by Ian Bull CLA
Modified: 2013-04-26 03:52 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2011-05-11 23:12:09 EDT 
In the Git Tree Compare, the icon used to "show files with equal content" is the same icon used (everywhere else) for linking views and editors. I just assumed this was a link action.

We should likely find a different icon as not to confuse other users.
Comment 1 Dani Megert CLA 2013-04-25 05:04:32 EDT 
And the filtered files in the tree should also not use that icon.
Comment 2 Dani Megert CLA 2013-04-25 07:19:50 EDT 
Pushed fix to Gerrit: https://git.eclipse.org/r/#/c/12178/
Comment 3 Robin Stocker CLA 2013-04-25 15:51:16 EDT 
Merged: http://git.eclipse.org/c/egit/egit.git/commit/?id=29f2ca999749bcebd028ef91ca5581c6b036c6ef

Also see bug 406535 for more improvements for the tree icons.
Comment 4 Dani Megert CLA 2013-04-26 03:52:01 EDT 
(In reply to comment #3)
> Merged:
> http://git.eclipse.org/c/egit/egit.git/commit/
> ?id=29f2ca999749bcebd028ef91ca5581c6b036c6ef
> 
> Also see bug 406535 for more improvements for the tree icons.

Thanks Robin.

Verified in 3.0.0.201304252313.