Description Brian de Alwis 2011-05-11 16:00:36 EDT

Created attachment 195420 [details]
patch to org.eclipse.e4.ui.workbench.renderers.swt.cocoa to add support for missing IDE commands

org.eclipse.ui.ide introduced references to 3 commands in the "Window" menu expected from MacOS X apps.  Implementations for these commands were put in org.eclipse.ui.cocoa.  The Eclipse 4 org.eclipse.e4.ui.workbench.renderers.swt.cocoa doesn't provide equivalent implementations, leading to messages on the console like the following:

   !ENTRY org.eclipse.ui 4 4 2011-05-10 20:14:24.880
   !MESSAGE Unable to create menu item "null", command
   "org.eclipse.ui.cocoa.minimizeWindow" not defined

   !ENTRY org.eclipse.ui 4 4 2011-05-10 20:14:24.881
   !MESSAGE Unable to create menu item "null", command
   "org.eclipse.ui.cocoa.zoomWindow" not defined

   !ENTRY org.eclipse.ui 4 4 2011-05-10 20:14:24.881
   !MESSAGE Unable to create menu item "null", command
   "org.eclipse.ui.cocoa.arrangeWindowsInFront" not defined

These warnings are a bit confusing and can be misleading (eg bug 345350).

The attached patch ports the E3.x implementations for these commands.  To simplify the addition, I did some minor rearrangement of the existing code.  There is no new API provided.