Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345401 - [validation] one of each of the warning() and error() methods drop issue data
Summary: [validation] one of each of the warning() and error() methods drop issue data
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 07:24 EDT by Knut Wannheden CLA
Modified: 2017-09-19 17:12 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Knut Wannheden CLA 2011-05-11 07:24:19 EDT
The methods AbstractDeclarativeValidator#error(String, EStructuralFeature, String, String...) and the corresponding AbstractDeclarativeValidator#warning(String, EStructuralFeature, String, String...) drop the passed issueData parameter:

	protected void error(String message, EStructuralFeature feature, String code, String... issueData) {
		error(message, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code);
	}

	protected void warning(String message, EStructuralFeature feature, String code, String... issueData) {
		warning(message, state.get().currentObject, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code);
	}

The methods should instead read:


	protected void error(String message, EStructuralFeature feature, String code, String... issueData) {
		error(message, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code, issueData);
	}

	protected void warning(String message, EStructuralFeature feature, String code, String... issueData) {
		warning(message, state.get().currentObject, feature, ValidationMessageAcceptor.INSIGNIFICANT_INDEX, code, issueData);
	}
Comment 1 Sebastian Zarnekow CLA 2011-05-13 08:45:37 EDT
Pushed to master.
Comment 2 Karsten Thoms CLA 2017-09-19 17:01:05 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:12:28 EDT
Closing all bugs that were set to RESOLVED before Neon.0