345372 – [KeyBindings] 'Delete' key cannot be used as a key bindings to a command

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 345372 - [KeyBindings] 'Delete' key cannot be used as a key bindings to a command

Summary: [KeyBindings] 'Delete' key cannot be used as a key bindings to a command

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.4
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.4 M3
Assignee:	Paul Webster
QA Contact:

URL:
Whiteboard:
Keywords:

Duplicates (1):	347854 (view as bug list)
Depends on:
Blocks:

Reported:	2011-05-11 04:04 EDT by David Pérez
Modified:	2013-10-02 04:37 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Proposed patch (348 bytes, patch) 2011-06-03 11:49 EDT, Cezar Lenci	cezar_cps: review?	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Pérez

2011-05-11 04:04:26 EDT

Build Identifier: 20110301-1815

Open the preference pages.
Go to the "Keys" page.
It's impossible to specify "Delete" for a new keybinding.
Other special keys like backspace or tab can be specified, from a popup menu, but "Delete" can't.  :-(

Reproducible: Always

Comment 1 Dani Megert

2011-05-11 06:56:44 EDT

Broken since 3.4.

Caused by wrong fix for bug 89610.

Comment 2 Markus Keller

2011-05-11 09:25:35 EDT

Workaround:
- press Ctrl+Delete
- with the mouse, select "Ctrl+"
- context menu > Delete
=> "Delete" stays

Comment 3 David Pérez

2011-05-12 04:25:54 EDT

I had tried this before submitting the bug.
It doesn't work for me.
If I select with the mouse "Ctrl+" and do "Delete", nothing happens.

(In reply to comment #2)
> Workaround:
> - press Ctrl+Delete
> - with the mouse, select "Ctrl+"
> - context menu > Delete
> => "Delete" stays

Comment 4 Paul Webster

2011-05-12 06:15:42 EDT

(In reply to comment #3)
> If I select with the mouse "Ctrl+" and do "Delete", nothing happens.

you right click and select delete from the context menu?

The comment #2 steps work in linux.

PW

Comment 5 David Pérez

2011-05-12 12:32:10 EDT

whereas I'm working in Windows XP.

(In reply to comment #4)
> The comment #2 steps work in linux.

Comment 6 Remy Suen

2011-05-12 12:44:59 EDT

Comment 2 works for me on Windows XP also.

Comment 7 Dani Megert

2011-06-01 02:36:46 EDT

*** Bug 347854 has been marked as a duplicate of this bug. ***

Comment 8 Cezar Lenci

2011-06-03 11:49:09 EDT

Created attachment 197312 [details]
Proposed patch

Proposed patch to add "Delete" to the TRAPPED_KEYS list, so it will be listed on the popup menu next to the binding field.

Comment 9 Paul Webster

2013-09-25 15:51:48 EDT

(In reply to Cezar Lenci from comment #8)
> Created attachment 197312 [details]
> Proposed patch

Cezar, if you accept the CLA I can push your patch.

PW

Comment 10 Cezar Lenci

2013-09-26 08:37:40 EDT

Done, CLA accepted.

Comment 11 Paul Webster

2013-09-26 09:46:53 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=75453d4ffdeac661f1f223ab8f17775e658bae65

Thanks Cezar.

PW

Comment 12 Dani Megert

2013-10-02 04:37:38 EDT

Verified in N20130929-2000.