Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 345364 - Cannot show table in MS-SQL if database has dash in name
Summary: Cannot show table in MS-SQL if database has dash in name
Status: NEW
Alias: None
Product: Data Tools
Classification: Tools
Component: Enablement (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: future   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 01:41 EDT by Ren Junyan CLA
Modified: 2011-05-17 03:20 EDT (History)
0 users

See Also:

Attachments
patch for this bug (4.40 KB, patch)
2011-05-17 03:20 EDT, Ren Junyan CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ren Junyan CLA 2011-05-11 01:41:45 EDT 
Build Identifier: I20090611-1540

Create database inside MS-SQL server called "dash-test", create table under database. Connect to MS-SQL with sqlserver enablement. When selecting 'schemas', it shows error as below.
"Incorrect syntax near '-'."

Reproducible: Always
Comment 1 Brian Fitzpatrick CLA 2011-05-11 13:51:03 EDT 
Ren, feel free to look at the MSSQL enablement code to see if you can find a way around this. I suspect that it's in the catalog loader that's grabbing tables with a custom SQL script. If you create a patch and verify that it works on your end we'll see if we can get it applied.
Comment 2 Ren Junyan CLA 2011-05-17 03:20:14 EDT 
Created attachment 195813 [details]
patch for this bug

A database name with dash character cannot be used in query directly in MS-SQL. There some sqls contain catalog name in enablement, which has risk when the name has dash. Now we quotes the catalog name by '[]', so that the query could be executed well.